Update flake lock file#46
Open
github-actions[bot] wants to merge 248 commits into
Open
Conversation
github-actions
Bot
force-pushed
the
nix-flake-update/master
branch
8 times, most recently
from
eb51276 to
082dd32
Compare
github-actions
Bot
force-pushed
the
nix-flake-update/master
branch
5 times, most recently
from
fb2599d to
ceefd97
Compare
github-actions
Bot
force-pushed
the
nix-flake-update/master
branch
7 times, most recently
from
3743260 to
2d3acea
Compare
github-actions
Bot
force-pushed
the
nix-flake-update/master
branch
2 times, most recently
from
b47921c to
3f0747c
Compare
github-actions
Bot
force-pushed
the
nix-flake-update/master
branch
5 times, most recently
from
e54c752 to
79423f4
Compare
github-actions
Bot
force-pushed
the
nix-flake-update/master
branch
3 times, most recently
from
a731662 to
0f40c5b
Compare
Summary: Add support for readv functions Reviewed By: mingtaoy Differential Revision: D40089998 fbshipit-source-id: 577a8f6c2bd1b833544ff7ce6400b4d3a9dc222f
Summary: GitHub commits: facebook/fbthrift@f9fb722 facebook/litho@2a81e00 facebook/proxygen@78f2f43 facebook/wangle@205b6a6 facebookexperimental/edencommon@c3a4ff2 facebookincubator/fizz@9c6f03c facebookincubator/katran@81e5213 facebook/mvfst@2a65b80 facebookincubator/velox@01444cf Reviewed By: apiri fbshipit-source-id: cafc7ae89975bf9f5ed338aafbbfd600e9f36011
Summary: Like it says in the title. Reviewed By: ndmitchell Differential Revision: D40514060 fbshipit-source-id: f3ccc2dd6fe406382cc978d7f637cb749290e92b
Summary: It was missing fl. Reviewed By: jano Differential Revision: D40461976 fbshipit-source-id: 30748e99e9d79d6d6ed0d383a55dd3d089e3e534
Summary: This will be a stack. At a high level we are bookkeeping decls to ensure we only sync O(changeset) decls every typecheck. This first diff gets things working end to end. I'll clean up a lot of this stuff in the following diffs. Reviewed By: nt591 Differential Revision: D40453936 fbshipit-source-id: bf9be5ab5c2a0f7788bc9138c8958747cf40b8fa
Summary: In D40442230 and D40453550, I failed to establish strong evidence that the multiplicative hashing in idhasher outperforms rustc_hash/FxHasher. Without perf evidence favoring idhasher, I suggest that we stop using idhasher altogether in favor of FxHasher. This way, the "right" way to write a map type is the same regardless of whether the keys happen to be integers (so long as collisions are acceptable and there is no reason to guard against DOS attempts): just write `hash::HashMap<K, V>`. ``` mulhasher parsing: (132+115+103+114)/4 = 116s mulhasher folding: (220+186+228+225)/4 = 214.75s fxhasher parsing: (110+105+126+133)/4 = 118.5s fxhasher folding: (217+263+123+222)/4 = 206.25s ``` Test output: ``` [jakebailey@devvm5921.prn0 ~/fbcode/hphp/hack (2c44b5efe)]$ br @//mode/opt-clang-thinlto src/hackrs:decl_repo_rust -- ~/www --fold --no-serialize File changed: fbcode//hphp/hack/src/hackrs/datastore/non_evicting.rs File changed: fbcode//hphp/hack/src/hackrs/datastore 5 additional file changes Buck UI: https://www.internalfb.com/buck2/8d745153-dec5-44d3-8e3f-151973efe7a0 RE: reSessionID-d2cb2173-1c0d-48ab-92b9-c331e223761f Up: 51 KiB Down: 5.3 MiB Jobs completed: 29. Time elapsed: 105.2s. Cache hits: 44%. Commands: 18 (cached: 8, remote: 9, local: 1) Collected 3582622 filenames in 13.063856072s Parsed 5930546 classes in repo in 110.006847858s RSS: 8.833GiB Folded 5930546 classes in repo in 216.939118785s RSS: 67.926GiB [jakebailey@devvm5921.prn0 ~/fbcode/hphp/hack (2c44b5efe)]$ br @//mode/opt-clang-thinlto src/hackrs:decl_repo_rust -- ~/www --fold --no-serialize Buck UI: https://www.internalfb.com/buck2/7ac3e2ab-e6e8-47d8-956f-afc39254dceb Jobs completed: 3. Time elapsed: 1.2s. Collected 3582622 filenames in 12.090519884s Parsed 5930546 classes in repo in 105.289884051s RSS: 8.975GiB Folded 5930546 classes in repo in 263.704592629s RSS: 66.613GiB [jakebailey@devvm5921.prn0 ~/fbcode/hphp/hack (2c44b5efe)]$ br @//mode/opt-clang-thinlto src/hackrs:decl_repo_rust -- ~/www --fold --no-serialize watchman fresh instance event, clearing cache Buck UI: https://www.internalfb.com/buck2/cbfff721-0785-4ecb-95bc-58737316f831 RE: reSessionID-f2c56733-1f25-4883-9bcb-039523046a45 Up: 35 MiB Down: 16 MiB Jobs completed: 3954. Time elapsed: 147.6s. Cache hits: 94%. Commands: 769 (cached: 725, remote: 34, local: 10) Collected 3582622 filenames in 11.295829653s Parsed 5930546 classes in repo in 126.384035499s RSS: 8.791GiB Folded 5930546 classes in repo in 122.802168159s RSS: 68.145GiB [jakebailey@devvm5921.prn0 ~/fbcode/hphp/hack (2c44b5efe)]$ br @//mode/opt-clang-thinlto src/hackrs:decl_repo_rust -- ~/www --fold --no-serialize Buck UI: https://www.internalfb.com/buck2/32e5b2b6-a836-43ac-b3c8-a1f781a1fd22 Jobs completed: 3. Time elapsed: 3.8s. Collected 3582622 filenames in 13.84893271s Parsed 5930546 classes in repo in 132.794275436s RSS: 8.877GiB Folded 5930546 classes in repo in 222.361536778s RSS: 67.336GiB ``` Reviewed By: edwinsmith Differential Revision: D40519256 fbshipit-source-id: 0ae430bcc7449bc023dc9cf50d58d1b822191909
Summary: I'm suggesting that we adopt a general policy of using FxHasher in all situations where DOS attacks or collisions are not a concern (see summary of previous diff). I think using the `hash` utility crate consistently might help guide people into that pit of success. Reviewed By: edwinsmith Differential Revision: D40365074 fbshipit-source-id: e7bb3b62e854b801247d6b45215d60e5d66dc9ed
Reviewed By: jamesjwu Differential Revision: D40518911 fbshipit-source-id: 8a42a9aae9155520a5b60ea085bf6a8238329e74
Summary: Fixed lint extras. Also changed input to mk_afkvalues() to be an iterator instead of a slice so we don't have to allocate an extra Vec. Reviewed By: edwinsmith Differential Revision: D40511947 fbshipit-source-id: f11c1d57b83540cd140f64526b914e4255446994
Summary: Temporarily removes usdt probe that causes error with OSS ld. This works on our lld linker. facebookincubator/fizz#84 Reviewed By: mingtaoy Differential Revision: D40523842 fbshipit-source-id: 8b914caa53350e3560c6990dd47d0876319cf274
Summary: We have a complicated infrastructure (making use of pointers to member functions) to track which classes might contain magic methods. Unfortunately this is all unused because the only magic method supported anymore is __toBoolean and that is special cased anyways. Get rid of find_magic_methods() and related. When we want to know if a class might contain a magic bool conversion, we can just do the check directly (it's simple). Reviewed By: oulgen, jano Differential Revision: D40540994 fbshipit-source-id: cd27523dc3486e5c14c24196a5be51d0d213edb1
Summary: * Fix a link. * Clarify that SimpleJSON uses names instead of IDs which affects schema evolution. * Minor wording cleanup while at it. Reviewed By: iahs Differential Revision: D40534553 fbshipit-source-id: b9e7774bad0428b158afb09e01fb857eee646012
Summary: X-link: facebook/folly#1879 Recreating D40510322 as an internal contributor The libc++ commit that introduced the change we need to work with: llvm/llvm-project@b82da8b#diff-720de38e87ca590a6946574a5c75c382720f1784dd63ba60deb0bb54bd827c43 Reviewed By: dmm-fb Differential Revision: D40555665 fbshipit-source-id: 16edb6b50a86407cf2daa8d4807c4b34b52354d0
pull Bot
pushed a commit
that referenced
this pull request
Jun 24, 2026
Summary:
Reproduces a heap-use-after-free where `Cpp2Channel::writeError` invokes `messageSendError()` on a freed `TransportUpgradeSendCallback` during connection teardown.
ASAN report:
```
==189==ERROR: AddressSanitizer: heap-use-after-free on address 0x506004b07dc0 at pc 0x55944737a034 bp 0x7f8fddb88a90 sp 0x7f8fddb88a88
READ of size 8 at 0x506004b07dc0 thread T529
SCARINESS: 51 (8-byte-read-heap-use-after-free)
#0 0x55944737a033 in apache::thrift::Cpp2Channel::writeError(unsigned long, apache::thrift::transport::TTransportException const&) fbcode/thrift/lib/cpp2/async/Cpp2Channel.cpp:150
...
#8 0x5594466740a8 in folly::futures::detail::CoreBase::doCallback(folly::ExecutorKeepAlive<folly::Executor>&&, folly::futures::detail::State) fbcode/folly/futures/detail/Core.cpp:614
#9 0x55944666eb6a in folly::futures::detail::CoreBase::setResult_(folly::ExecutorKeepAlive<folly::Executor>&&) fbcode/folly/futures/detail/Core.cpp:515
#10 0x55944663d29c in folly::futures::detail::Core<folly::Unit>::setResult(folly::ExecutorKeepAlive<folly::Executor>&&, folly::Try<folly::Unit>&&) fbcode/folly/futures/detail/Core.h:670
#11 0x55944663d29c in folly::futures::detail::Core<folly::Unit>::setResult(folly::Try<folly::Unit>&&) fbcode/folly/futures/detail/Core.h:656
#12 0x55944663d29c in folly::Promise<folly::Unit>::setTry(folly::Try<folly::Unit>&&) fbcode/folly/futures/Promise-inl.h:131
#13 0x5594474b048d in folly::SharedPromise<folly::Unit>::setTry(folly::Try<folly::Unit>&&) fbcode/folly/futures/SharedPromise-inl.h:97
...
#34 0x55944734a943 in wangle::OutputBufferingHandler::runLoopCallback() fbcode/wangle/channel/OutputBufferingHandler.h:64
#35 0x55944668c0d7 in folly::EventBase::runLoopCallbackList(boost::intrusive::list<folly::EventBase::LoopCallback, boost::intrusive::constant_time_size<false>>&, folly::EventBase::LoopCallbacksDeadline const&) fbcode/folly/io/async/EventBase.cpp:1028
#36 0x55944667f94b in folly::EventBase::runLoopCallbacks() fbcode/folly/io/async/EventBase.cpp:1049
#37 0x55944668a0f8 in folly::EventBase::loopMain(int, folly::EventBase::LoopOptions) fbcode/folly/io/async/EventBase.cpp:657
#38 0x55944668781a in folly::EventBase::loopBody(int, folly::EventBase::LoopOptions) fbcode/folly/io/async/EventBase.cpp:539
#39 0x55944668781a in folly::EventBase::loop() fbcode/folly/io/async/EventBase.cpp:500
#40 0x55944668d708 in folly::EventBase::loopForever() fbcode/folly/io/async/EventBase.cpp:811
#41 0x5594467155ff in folly::IOThreadPoolExecutor::threadRun(std::shared_ptr<folly::ThreadPoolExecutor::Thread>) fbcode/folly/executors/IOThreadPoolExecutor.cpp:288
...
#46 0x7f9316b2ce4b in __GI___clone3 /home/engshare/third-party2/glibc/2.34/src/glibc-2.34/misc/../sysdeps/unix/sysv/linux/x86_64/clone3.S:81
0x506004b07dc0 is located 0 bytes inside of 56-byte region [0x506004b07dc0,0x506004b07df8)
freed by thread T529 here:
#0 0x55946670ff02 in operator delete(void*, unsigned long) (/thatch_package/thatch_vm/thatch_vm+0x2befaf02) (BuildId: 56231c3862d0070bdddfcef427b9b87e7d419753)
#1 0x559449700745 in std::default_delete<apache::thrift::MessageChannel::SendCallback>::operator()(apache::thrift::MessageChannel::SendCallback*) const fbcode/third-party-buck/platform010/build/libgcc/include/c++/trunk/bits/unique_ptr.h:85
#2 0x559449700745 in std::unique_ptr<apache::thrift::MessageChannel::SendCallback, std::default_delete<apache::thrift::MessageChannel::SendCallback>>::~unique_ptr() fbcode/third-party-buck/platform010/build/libgcc/include/c++/trunk/bits/unique_ptr.h:361
#3 0x559449700745 in apache::thrift::Cpp2Connection::~Cpp2Connection() fbcode/thrift/lib/cpp2/server/Cpp2Connection.cpp:165
#4 0x559449701ef0 in std::_Sp_counted_base<(__gnu_cxx::_Lock_policy)2>::_M_release() fbcode/third-party-buck/platform010/build/libgcc/include/c++/trunk/bits/shared_ptr_base.h:186
#5 0x559449701ef0 in std::__shared_count<(__gnu_cxx::_Lock_policy)2>::~__shared_count() fbcode/third-party-buck/platform010/build/libgcc/include/c++/trunk/bits/shared_ptr_base.h:767
#6 0x559449701ef0 in std::__shared_ptr<apache::thrift::Cpp2Connection, (__gnu_cxx::_Lock_policy)2>::~__shared_ptr() fbcode/third-party-buck/platform010/build/libgcc/include/c++/trunk/bits/shared_ptr_base.h:1216
#7 0x559449701ef0 in std::__shared_ptr<apache::thrift::Cpp2Connection, (__gnu_cxx::_Lock_policy)2>::reset() fbcode/third-party-buck/platform010/build/libgcc/include/c++/trunk/bits/shared_ptr_base.h:1334
#8 0x559449701ef0 in apache::thrift::Cpp2Connection::stop() fbcode/thrift/lib/cpp2/server/Cpp2Connection.cpp:226
#9 0x5594496f06b4 in apache::thrift::Cpp2Connection::channelClosed(folly::exception_wrapper&&)::$_0::operator()() const fbcode/thrift/lib/cpp2/server/Cpp2Connection.cpp:753
#10 0x5594496f06b4 in void folly::catch_exception<apache::thrift::Cpp2Connection::channelClosed(folly::exception_wrapper&&)::$_0&, void (*)() noexcept, void>(apache::thrift::Cpp2Connection::channelClosed(folly::exception_wrapper&&)::$_0&, void (*&&)() noexcept) fbcode/folly/lang/Exception.h:361
#11 0x5594496f06b4 in folly::detail::ScopeGuardImpl<apache::thrift::Cpp2Connection::channelClosed(folly::exception_wrapper&&)::$_0, true>::execute() fbcode/folly/ScopeGuard.h:181
#12 0x5594496f06b4 in folly::detail::ScopeGuardImpl<apache::thrift::Cpp2Connection::channelClosed(folly::exception_wrapper&&)::$_0, true>::~ScopeGuardImpl() fbcode/folly/ScopeGuard.h:154
#13 0x5594496f06b4 in apache::thrift::Cpp2Connection::channelClosed(folly::exception_wrapper&&) fbcode/thrift/lib/cpp2/server/Cpp2Connection.cpp:757
#14 0x5594499f1274 in apache::thrift::HeaderServerChannel::messageReceiveErrorWrapped(folly::exception_wrapper&&) fbcode/thrift/lib/cpp2/async/HeaderServerChannel.cpp:443
#15 0x5594473469e9 in apache::thrift::Cpp2Channel::readException(wangle::HandlerContext<int, std::pair<std::unique_ptr<folly::IOBuf, std::default_delete<folly::IOBuf>>, apache::thrift::transport::THeader*>>*, folly::exception_wrapper) fbcode/thrift/lib/cpp2/async/Cpp2Channel.cpp:123
#16 0x559447357e7f in wangle::ContextImpl<apache::thrift::Cpp2Channel>::readException(folly::exception_wrapper) fbcode/wangle/channel/HandlerContext-inl.h:303
#17 0x55944735df83 in wangle::ContextImpl<apache::thrift::FramingHandler>::fireReadException(folly::exception_wrapper) fbcode/wangle/channel/HandlerContext-inl.h:214
#18 0x559446f1ae77 in wangle::Handler<folly::IOBufQueue&, std::pair<std::unique_ptr<folly::IOBuf, std::default_delete<folly::IOBuf>>, std::unique_ptr<apache::thrift::transport::THeader, std::default_delete<apache::thrift::transport::THeader>>>, std::pair<std::unique_ptr<folly::IOBuf, std::default_delete<folly::IOBuf>>, apache::thrift::transport::THeader*>, std::unique_ptr<folly::IOBuf, std::default_delete<folly::IOBuf>>>::readException(wangle::HandlerContext<std::pair<std::unique_ptr<folly::IOBuf, std::default_delete<folly::IOBuf>>, std::unique_ptr<apache::thrift::transport::THeader, std::default_delete<apache::thrift::transport::THeader>>>, std::unique_ptr<folly::IOBuf, std::default_delete<folly::IOBuf>>>*, folly::exception_wrapper) fbcode/wangle/channel/Handler.h:66
#19 0x559447360c1f in wangle::ContextImpl<apache::thrift::FramingHandler>::readException(folly::exception_wrapper) fbcode/wangle/channel/HandlerContext-inl.h:303
#20 0x5594473690f3 in wangle::ContextImpl<apache::thrift::TAsyncTransportHandler>::fireReadException(folly::exception_wrapper) fbcode/wangle/channel/HandlerContext-inl.h:214
#21 0x559447370f3a in apache::thrift::TAsyncTransportHandler::readErr(folly::AsyncSocketException const&) fbcode/thrift/lib/cpp2/async/TAsyncTransportHandler.h:132
#22 0x5594494daea2 in fizz::AsyncFizzBase::deliverError(folly::AsyncSocketException const&, bool) fbcode/fizz/protocol/AsyncFizzBase.cpp:330
#23 0x559449ae75f7 in fizz::server::AsyncFizzServerT<fizz::server::ServerStateMachine>::deliverAllErrors(folly::AsyncSocketException const&, bool) fbcode/fizz/server/AsyncFizzServer-inl.h:283
#24 0x559449ae3b79 in fizz::server::AsyncFizzServerT<fizz::server::ServerStateMachine>::transportError(folly::AsyncSocketException const&) fbcode/fizz/server/AsyncFizzServer-inl.h:253
#25 0x5594494dce93 in fizz::AsyncFizzBase::readErr(folly::AsyncSocketException const&) fbcode/fizz/protocol/AsyncFizzBase.cpp:449
#26 0x5594494dce93 in non-virtual thunk to fizz::AsyncFizzBase::readErr(folly::AsyncSocketException const&) fbcode/fizz/protocol/AsyncFizzBase.h
#27 0x559446f0a4a2 in folly::AsyncSocket::invokeAllErrors(folly::AsyncSocketException const&) fbcode/folly/io/async/AsyncSocket.cpp:4300
#28 0x559446f0a4a2 in folly::AsyncSocket::finishFail(folly::AsyncSocketException const&) fbcode/folly/io/async/AsyncSocket.cpp:4317
#29 0x559446f0a4a2 in folly::AsyncSocket::failWrite(char const*, folly::AsyncWriter::WriteCallback*, unsigned long, folly::AsyncSocketException const&) fbcode/folly/io/async/AsyncSocket.cpp:4420
#30 0x559446f08bea in folly::AsyncSocket::writeImpl(folly::AsyncWriter::WriteCallback*, iovec const*, unsigned long, std::unique_ptr<folly::IOBuf, std::default_delete<folly::IOBuf>>&&, unsigned long, folly::WriteFlags) fbcode/folly/io/async/AsyncSocket.cpp:2012
#31 0x559446f09753 in folly::AsyncSocket::writeChainImpl(folly::AsyncWriter::WriteCallback*, iovec*, unsigned long, std::unique_ptr<folly::IOBuf, std::default_delete<folly::IOBuf>>&&, folly::WriteFlags) fbcode/folly/io/async/AsyncSocket.cpp:1937
#32 0x559446ed1e75 in folly::AsyncSocket::writeChain(folly::AsyncWriter::WriteCallback*, std::unique_ptr<folly::IOBuf, std::default_delete<folly::IOBuf>>&&, folly::WriteFlags) fbcode/folly/io/async/AsyncSocket.cpp:1907
...
#44 0x5594494d95a9 in fizz::AsyncFizzBase::writeChain(folly::AsyncWriter::WriteCallback*, std::unique_ptr<folly::IOBuf, std::default_delete<folly::IOBuf>>&&, folly::WriteFlags) fbcode/fizz/protocol/AsyncFizzBase.cpp:218
#45 0x55944736fd3d in apache::thrift::TAsyncTransportHandler::write(wangle::HandlerContext<folly::IOBufQueue&, std::unique_ptr<folly::IOBuf, std::default_delete<folly::IOBuf>>>*, std::unique_ptr<folly::IOBuf, std::default_delete<folly::IOBuf>>) fbcode/thrift/lib/cpp2/async/TAsyncTransportHandler.h:91
#46 0x55944736c9a1 in wangle::ContextImpl<apache::thrift::TAsyncTransportHandler>::write(std::unique_ptr<folly::IOBuf, std::default_delete<folly::IOBuf>>) fbcode/wangle/channel/HandlerContext-inl.h:319
#47 0x55944736dad1 in non-virtual thunk to wangle::ContextImpl<apache::thrift::TAsyncTransportHandler>::write(std::unique_ptr<folly::IOBuf, std::default_delete<folly::IOBuf>>) fbcode/wangle/channel/HandlerContext-inl.h
```
Reviewed By: mshneer
Differential Revision: D109055907
fbshipit-source-id: 67f3cdba1b327e11b19eef44831b9905cc3e2048
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated changes by create-pull-request GitHub action