[core] Add KlioWriteToText missing fields including file_name_suffix,…#200
Open
shireen-bean wants to merge 3 commits intodevelopfrom
Open
[core] Add KlioWriteToText missing fields including file_name_suffix,…#200shireen-bean wants to merge 3 commits intodevelopfrom
shireen-bean wants to merge 3 commits intodevelopfrom
Conversation
econchick
reviewed
Jul 2, 2021
Contributor
econchick
left a comment
There was a problem hiding this comment.
Thanks for fixing this! Looks like a workflow/test is failing and needs fixing. Just had a couple of questions, otherwise it looks good.
Not sure when to release it though - maybe in 21.7.0.alpha1?
84b0f1d to
1d11f3d
Compare
… num_shards, append_trailing_newlines etc
… num_shards, append_trailing_newlines etc
f357e90 to
e34273a
Compare
… num_shards, append_trailing_newlines etc
e34273a to
0fc3219
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Add KlioWriteToText missing fields including file_name_suffix, num_shards, append_trailing_newlines etc
A user reported his job erroring out when providing
file_name_suffixwhen default event output was enabled in batch mode.This PR enables missing fields for KlioWriteToText that are available in the beam conterpart.
Testing
Added a test use case for having more than the bare minimum configuration fields for the KlioWriteFileConfig.
Tested this on a job using klio devtools for a test batch job. Tested to ensure that the job would continue to work with just:
as well as work with the config:
Checklist for PR author(s)
[cli] Fixes bugs in 'klio job fake-cmd'.docs/src.docs/src/reference/<package>/changelog.rst.