Introduce ErrorProne, fix compiler warnings #4807
Draft
+662
−708
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
scordio
force-pushed
the
cosmetic
branch
2 times, most recently
from
8eb3acc to
8a6ddaf
Compare
|
This is fantastic! Thank you for doing that, @scordio ! I have a plan to re-work/optimise the project's build/release process for the next major release (see #4319 as well), and this goes in that same direction. When this is not a draft PR anymore, please let me know and it should be welcome to merge. |
scordio
force-pushed
the
cosmetic
branch
5 times, most recently
from
f0efc64 to
459933c
Compare
scordio
force-pushed
the
cosmetic
branch
4 times, most recently
from
33ce508 to
b662b2d
Compare
Signed-off-by: Stefano Cordio <stefano.cordio@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces ErrorProne, sets the
maven-compiler-pluginto fail in case of compiler warnings, and fixes all the warnings.This is a preparation for: