Skip to content

fix: add GithubIcon 'w' and 'h' props#46

Open
jt-ziolo wants to merge 1 commit into
staticwebdev:mainfrom
jt-ziolo:patch-1
Open

fix: add GithubIcon 'w' and 'h' props#46
jt-ziolo wants to merge 1 commit into
staticwebdev:mainfrom
jt-ziolo:patch-1

Conversation

@jt-ziolo

Copy link
Copy Markdown

On line 68 of [path].js:

<GithubIcon w={24} h={24} />

the props w and h are excluded from the definition of GithubIcon (lines 229 - 244 of Icons.js):

export function GithubIcon() { // should be GithubIcon({ w, h })
  return (
    <svg
      xmlns="http://www.w3.org/2000/svg"
      width="24" // should be {w}
      height="24" // should be {h}
      fill="none"
      viewBox="0 0 24 24"
    >
      <path
	// ...
	></path>
    </svg>
  );
}
Fixed the following issue:
On line 68 of [path].js, the props ``w`` and ``h`` are passed into GithubIcon, but these props are excluded from the definition of GithubIcon (lines 229 - 244 of Icons.js).
@jt-ziolo jt-ziolo marked this pull request as ready for review June 29, 2023 05:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

1 participant