Fix Int? argument issues on 32-bit environments#667
Open
sidepelican wants to merge 7 commits intoswiftlang:mainfrom
Open
Fix Int? argument issues on 32-bit environments#667sidepelican wants to merge 7 commits intoswiftlang:mainfrom
Int? argument issues on 32-bit environments#667sidepelican wants to merge 7 commits intoswiftlang:mainfrom
Conversation
# Conflicts: # Sources/JExtractSwiftLib/JNI/JNIJavaTypeTranslator.swift
# Conflicts: # Sources/JExtractSwiftLib/JNI/JNISwift2JavaGenerator+JavaTranslation.swift # Sources/JExtractSwiftLib/JNI/JNISwift2JavaGenerator+SwiftThunkPrinting.swift
Contributor
Author
|
Sorry, I forgot to point this out; This PR requires swiftlang/swift-java-jni-core#16 to be merged first. |
Collaborator
|
I see... let's get some Android folks to chime in here, @madsodgaard has an interest in keeping those 32bit runtimes happy. |
Contributor
|
If I'm reading this right, I do think it introduces peril for 32-bit platforms like armv7 on Android and other embedded devices. In swiftlang/swift-java-jni-core#16 (comment) I suggest simply dropping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issues related to
Int?arguments on 32-bit architectures.The generated code contained numerous errors. (The failing CI run: https://github.com/swiftlang/swift-java/actions/runs/23786261629/job/69318324924 )
Background
During my investigation, I realized that the dynamic nature of
Int.JNITypewas significantly complicating the logic.I have already submitted a PR to address this: swiftlang/swift-java-jni-core#16
In this PR, I have removed the various implementation pieces that were previously used to manually wrap
IntintoInt64.With the unified
JNIType, these are no longer necessary, and removing them resolves the original problem.Verification
I have verified that the generated code compiles correctly for 32-bit by running the following command in SwiftJavaExtractJNISampleApp:
./gradlew assemble -PswiftSdk=armv7-unknown-linux-android28While the compilation is successful, I do not have a 32-bit Android runtime environment, so I haven't been able to verify the actual execution results.