Add @_transparent to some more Integer operations #80712
Merged
+4
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci test |
@_transparent will ensure there are inlined in MandatoryInlining which runs before OSLogOptimization.
OSLogOptimization does not look through their calls because they are not marked with
@_semantics("constant_evaluable") which requires them to also be annotated as @_optimize(none)
rdar://148256435
meg-gupta
changed the title
FixedWidthInteger.bitwidth
|
@swift-ci test |
|
@swift-ci apple silicon benchmark |
|
@swift-ci benchmark |
|
@swift-ci test |
|
@swift-ci apple silicon benchmark |
|
@swift-ci benchmark |
ravikandhadai
approved these changes
Apr 18, 2025
|
@swift-ci test |
matthewseaman
approved these changes
Apr 19, 2025
|
Benchmark failures are present in baseline. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#79707 made some integer operations transparent enabling them to be inlined during
MandatoryInlining. With thisOSLogOptimizationneeds to analyze the inlined function bodies of these integer operations since it runs afterMandatoryInlining.In certain configurations, stdlib's
FixedWidthInteger.bitwidthand others are not inlined andOSLogOptimizationmisses to determine these calls as constants.OSLogOptimizationcan look through calls to functions annotated with@_semantics(constant_evaluable).But annotating with
@_semantics(constant_evaluable)seems to require annotating with@_optimize(none). Instead annotate with@_transparent.Fixes oslog tests when stdlib is built with -Osize/-Onone - rdar://148256435 and rdar://148302110