[6.2][Sema/SILGen] Import ObjC async functions as nonisolated(nonsending) by default #80957
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…` by default These functions already have special code generation that keeps them in the caller's isolation context, so there is no behavior change here. Resolves: rdar://145672343 (cherry picked from commit 07bad98)
…to native thunks. We do not actually hop since we know that (cherry picked from commit f309d1b)
…ated parameters of a native function. (cherry picked from commit 61ff4a9)
(cherry picked from commit e5d911f)
…d `@objc` async handlers to be `@concurrent This is behavior pre-SE-0461 which is the safest option instead of inferring `nonisolated(nonsending)` and changing the calling convention and foregoing Sendable checking. (cherry picked from commit c25d2fa)
|
@swift-ci please test |
hborla
approved these changes
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #79717
Explanation:
This was discussed as part of SE-0461 proposal. These functions already have special code generation that keeps them in the caller's isolation context, so there is no behavior change here.
Main Branch PR: [Sema/SILGen] Import ObjC async functions as
nonisolated(nonsending)by … #79717Risk: Low (The change affects only default isolation of the async ObjC declarations, code generation stays the same as do overrides, it should be transparent from the use perspective as
nonisolated(nonsending)has a very flexible conversion scheme).Reviewed By: @gottesmm
Resolves: rdar://145672343
Testing: Added new tests to the test suite.