-
Notifications
You must be signed in to change notification settings - Fork 939
Don't create hypertable for published tables #7911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7911 +/- ##
==========================================
+ Coverage 80.06% 81.86% +1.79%
==========================================
Files 190 249 +59
Lines 37181 46149 +8968
Branches 9450 11571 +2121
==========================================
+ Hits 29770 37778 +8008
- Misses 2997 3807 +810
- Partials 4414 4564 +150 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
798e183
to
f3b8d8e
Compare
Don't need to refer the issue in the PR subject but instead add a "Fixe #7208" at the end of PR description. For reference: https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword#linking-a-pull-request-to-an-issue-using-a-keyword Also is good to add a more descriptive commit why is necessary this change. And please add a "thanks" to the person that reported the issue into the changelog entry. |
8d5d13f
to
473da08
Compare
Logical Replication of hypertables is not supported (for implementation reasons). We do not allow creation of hypertables with publications and now throw an error if attempted.
@fabriziomello @Poroma-Banerjee This change doesn't disallow tables which are added to publication using
|
Logical Replication of hypertables is not supported (for implementation reasons). We do not allow creation of hypertables
with publications and now throw an error if attempted.
Closes #7208