machine/rp2: merge common usb code#4856
Merged
deadprogram merged 2 commits intotinygo-org:devfrom Apr 15, 2025
Merged
Conversation
eliasnaur
approved these changes
Apr 12, 2025
Contributor
eliasnaur
left a comment
eliasnaur
left a comment
There was a problem hiding this comment.
LGTM and thank you. I verified that machine_rp2_usb.go is a straightforward copy of code common to the machine_rp2xxx_usb.go files.
Member
|
Thank you very much for splitting out this PR and for the excellent work overall @mikesmitty this is very exciting! Also thanks for the detailed reviews @eliasnaur ⭐ Now squash/merging. |
Contributor
Author
|
Thanks! |
deadprogram
pushed a commit
that referenced
this pull request
Aug 16, 2025
* machine/rp2: merge common usb code * chore: add note on noinline reason
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originating from a comment by @eliasnaur on #4850, this merges the shared components of the rp2 USB stacks