Skip to content

Downgrade d3 to v3. - #70

Closed
vicapow wants to merge 1 commit into
uber:masterfrom
vicapow:downgrade-d3
Closed

Downgrade d3 to v3.#70
vicapow wants to merge 1 commit into
uber:masterfrom
vicapow:downgrade-d3

Conversation

@vicapow

@vicapow vicapow commented Sep 19, 2018

Copy link
Copy Markdown
Contributor

No description provided.

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@vicapow

vicapow commented Sep 19, 2018

Copy link
Copy Markdown
Contributor Author

graph-view.js uses d3 transition. this is a d3 v3 api.

@vicapow

vicapow commented Sep 19, 2018

Copy link
Copy Markdown
Contributor Author

likely related to #71

@NameFILIP

NameFILIP commented Sep 19, 2018

Copy link
Copy Markdown
Contributor

I've checked and looks like the downgrade fixes this, but then I get d3.zoom is not a function, so it might not be a solution.

@ajbogh

ajbogh commented Sep 19, 2018

Copy link
Copy Markdown
Contributor

@vicapow Please provide an issue number with the PR and make sure to sign the CLA.

@ajbogh

ajbogh commented Sep 19, 2018

Copy link
Copy Markdown
Contributor

Alternatively, instead of downgrading d3 (which is not desirable), please create a PR which fixes the code. If the transition API needs to be used differently then please modify that part of the code. If you don't want to create a PR then please create an Issue with the bug described, any console messages or visual details, and reproduction steps listed. Thanks!

@vicapow

vicapow commented Sep 19, 2018

Copy link
Copy Markdown
Contributor Author

This is broken on master. I recommend landing this and upgrading d3 later. The issue number was provided above. #71

@NameFILIP

Copy link
Copy Markdown
Contributor

to clarify, I haven't been able to verify if downgrading fixes the issue. I'd investigate more why exactly the error is happening

@ajbogh

ajbogh commented Oct 4, 2018

Copy link
Copy Markdown
Contributor

I'm going to close this PR as the CLA hasn't been signed and the bug is fixed in #74.

@ajbogh ajbogh closed this Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants