Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
This PR consolidates the recent GUI/runtime work into a cleaner platform split, restores the real-GUI grounding path, and updates docs to match the current implementation.
Key changes:
packages/guidocs so platform support reflects the current codeWhy
The previous implementation had started to grow platform-specific behavior inside a single runtime path, which made capability reporting, cleanup, and Windows support inconsistent. This change makes the platform boundary explicit, fixes the real GUI grounding regression we found during review, and removes outdated documentation that still said Windows GUI support was only planned.
Impact
Validation
pnpm lint(passes with 5 pre-existing warnings outside this PR's changed areas)pnpm -C /Users/songliang/workspace/Understudy/understudy --filter @understudy/gui run typecheckpnpm -C /Users/songliang/workspace/Understudy/understudy exec vitest --run packages/gui/src/__tests__/platform.test.ts packages/gui/src/__tests__/runtime.test.ts --testNamePattern="Windows|win32"pnpm test:gui:real:groundingwas run successfully after the macOS regression fixes. A final rerun from the current active desktop session did not complete promptly, so it was not used as the final gate for this PR.Notes
Windows still does not support
windowSelector.indexor teach-by-demonstration recording. The backend is now an explicit MVP rather than a claim of full parity with macOS.