Conversation
Flo4604
added this pull request to stack #7678
October 1, 2026 11:07
Flo4604
force-pushed
the
cleanup/removal-protocol
branch
from
October 1, 2026 11:28
350cee1 to
54f03df
Compare
Flo4604
force-pushed
the
cleanup/removal-protocol
branch
from
October 1, 2026 11:49
54f03df to
102ae4a
Compare
Derive permanent removal from missing or deleting ancestors. Recover lost acknowledgments and notify Krane when an already-stopped topology needs cleanup, without reconciling settled snapshot rows. Deploy ctrl before the new Krane client, which requires deployment IDs on delete events. Amp-Thread-ID: https://ampcode.com/threads/T-01a0c960-4827-7091-bd71-bb8b7aa78f9c Co-authored-by: Amp <amp@ampcode.com>
Amp-Thread-ID: https://ampcode.com/threads/T-01a0c960-4827-7091-bd71-bb8b7aa78f9c Co-authored-by: Amp <amp@ampcode.com>
Flo4604
force-pushed
the
cleanup/removal-protocol
branch
from
October 1, 2026 13:29
102ae4a to
753af84
Compare
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to ensure that even if an environment/app/project is deleted and some rows still exists that we detect and repair them automatically.
We now confirm to ctrl that removal is done.