Creating a list of annotations allowed to treat package as annotated #1297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current issues is that any comment matching annotation --% is pushed into ut cache packages which causes exclusion from coverage reports.
…ture/issue_1278
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1297 +/- ##
========================================
Coverage 94.97% 94.98%
========================================
Files 111 111
Lines 5396 5403 +7
Branches 34 33 -1
========================================
+ Hits 5125 5132 +7
Misses 271 271
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve #1278
Root problem is the issue that package is being treated as annotate which allows it to be pushed into cache_suite table.
The solution is the do not treat object as annotated if the
--%does not contain a valid annotation that is specified by framework.e.g. ignore comments like --%parameter
This will allow for greater flexibility for documenting.