Skip to content

Conversation

@utkarshdalal
Copy link
Owner

@utkarshdalal utkarshdalal commented Dec 20, 2025

Summary by CodeRabbit

Release Notes

  • Bug Fixes

    • Corrected Visual C++ installation splash screen text.
  • Updates

    • Updated core emulation components to latest versions.
    • Enhanced graphics driver and wrapper configurations for improved compatibility.
    • Added support for a new graphics API version option.
    • Improved system directory resolution for better stability.

✏️ Tip: You can customize this high-level summary in your review settings.

@utkarshdalal utkarshdalal merged commit eb30d1b into master Dec 20, 2025
1 of 2 checks passed
@utkarshdalal utkarshdalal deleted the fex+box-extractionfix branch December 20, 2025 21:32
@coderabbitai
Copy link

coderabbitai bot commented Dec 20, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Updates default container graphics driver configurations and component version constants. Refactors wine path resolution to use fixed static paths. Simplifies extraction logic in launcher components to decouple version checks from asset application. Adds VKD3D version entry and increments FEXCORE constant.

Changes

Cohort / File(s) Summary
Configuration & Version Updates
app/src/main/java/com/winlator/core/DefaultVersion.java, app/src/main/res/values/arrays.xml
Bumped FEXCORE constant from "2511" to "2512"; added VKD3D version entry "3.0b" to vkd3d_version_entries array.
Container Defaults
app/src/main/java/app/gamenative/utils/ContainerUtils.kt
Switched Turnip-capable scenarios to Wrapper-based setup (BIONIC variant, proton-9.0-arm64ec, "Wrapper" driver, async-1.10.3 DXVK). Updated non-Turnip driver from "Wrapper-leegao" to "Wrapper". VKD3D updated to "2.14.1" in both paths.
Wine Path Resolution
app/src/main/java/com/winlator/xenvironment/WineUtils.java
Simplified wine system directory paths from dynamic rootDir/wineInfo-based resolution to static rootDir/opt/wine/lib/wine/{x86_64-windows,i386-windows}.
Component Extraction Logic
app/src/main/java/com/winlator/xenvironment/components/BionicProgramLauncherComponent.java, app/src/main/java/com/winlator/xenvironment/components/GlibcProgramLauncherComponent.java
Decoupled extraction from version checks. Both components now unconditionally apply ContentProfiles when available, with extraction fallback. Ensured container data updates and version tracking in all code paths.
UI Text
app/src/main/java/app/gamenative/ui/screen/xserver/XServerScreen.kt
Changed boot splash text from "Installing Visual C++ Redistributable..." to "Installing Visual C++ Redistributables...".

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

  • BionicProgramLauncherComponent & GlibcProgramLauncherComponent: Logic refactoring for extraction and profile application; verify fallback paths are correct and containerDataChanged is set in all branches.
  • ContainerUtils.kt: Turnip-specific configuration changes; confirm variant/driver/version mappings are correct for both Turnip and non-Turnip paths.
  • WineUtils.java: Static path resolution change; verify fixed paths are always valid across all scenarios.

Possibly related PRs

Suggested reviewers

  • phobos665

Poem

🐰 The configs hop and dance with grace,
Path-finding simplified in place,
Wine flows through static routes so clear,
While extractors now no longer fear—
Each profile applied with gentle care,
VKD3D blooms beyond compare!

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fex+box-extractionfix

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 43b99cf and 3b03db8.

📒 Files selected for processing (7)
  • app/src/main/java/app/gamenative/ui/screen/xserver/XServerScreen.kt (1 hunks)
  • app/src/main/java/app/gamenative/utils/ContainerUtils.kt (1 hunks)
  • app/src/main/java/com/winlator/core/DefaultVersion.java (1 hunks)
  • app/src/main/java/com/winlator/core/WineUtils.java (1 hunks)
  • app/src/main/java/com/winlator/xenvironment/components/BionicProgramLauncherComponent.java (1 hunks)
  • app/src/main/java/com/winlator/xenvironment/components/GlibcProgramLauncherComponent.java (1 hunks)
  • app/src/main/res/values/arrays.xml (1 hunks)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants