Skip to content

Migrate linting from standard to XO - #53

Merged
leo merged 1 commit into
vercel:masterfrom
jfmengels:xo
Oct 15, 2016
Merged

leo merged 1 commit into
vercel:masterfrom
jfmengels:xo

Conversation

@jfmengels

Copy link
Copy Markdown
Contributor

Migrate linting from standard to XO, to have a consistent linter and style accross the Zeit projects, as requested by @leo.

Notes:

  • I also added 'xo's react config for this project.
  • There are two proptypes that seem to not be used explicitly. From what I gather, they are accessed and used dynamically, so I ignored the warnings there.
@leo

leo commented Oct 15, 2016

Copy link
Copy Markdown
Contributor

Thanks! But why do we need to use babel-eslint as a parser? Isn't esnext: true enough?

@jfmengels

Copy link
Copy Markdown
Contributor Author

xo supports jsx syntax out of the box, but you need babel-eslint to support not-yet standard features. In this case, you're using static class properties, which is not yet supported by the default parser.

@leo

leo commented Oct 15, 2016

Copy link
Copy Markdown
Contributor

Ahhhh. Thanks! 😊

@leo
leo merged commit 40e1aa9 into vercel:master Oct 15, 2016
@jfmengels
jfmengels deleted the xo branch October 15, 2016 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants