Skip to content

Rename new-trace-viewer to trace-viewer - #3298

Merged
mitul-s merged 2 commits into
c-ms/remove-old-trace-viewerfrom
c-ms/rename-new-trace-viewer-to-trace-viewer
Aug 3, 2026
Merged

Rename new-trace-viewer to trace-viewer#3298
mitul-s merged 2 commits into
c-ms/remove-old-trace-viewerfrom
c-ms/rename-new-trace-viewer-to-trace-viewer

Conversation

@mitul-s

@mitul-s mitul-s commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

Description

Stacked on #3296.

Renames new-trace-viewer/trace-viewer/, the public NewTraceViewer export → TraceViewer, and the wrapper trace-viewer-new.tsxtrace-viewer.tsx. Updates @workflow/web consumers, the build CSS copy path, README, and tests accordingly.

Breaking: replace NewTraceViewer imports with TraceViewer.

How did you test your changes?

  • pnpm -F @workflow/web-shared typecheck
  • pnpm -F @workflow/web-shared test — 154 passed
  • pnpm -F @workflow/web-shared build
  • pnpm -F @workflow/web test — 97 passed

PR Checklist - Required to merge

  • 📦 pnpm changeset was run to create a changelog for this PR
    • Use the correct semver bump type: patch for bug fixes, minor for new features, major for breaking changes.
    • Use pnpm changeset --empty if you are changing documentation or workbench apps
  • 🔒 DCO sign-off passes (run git commit --signoff on your commits)
  • 📝 Ping @vercel/workflow in a comment once the PR is ready, and the above checklist is complete

Made with Cursor

@mitul-s
mitul-s requested review from a team and ijjk as code owners August 3, 2026 18:52
@changeset-bot

changeset-bot Bot commented Aug 3, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: ea48f8c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 16 packages
Name Type
@workflow/web-shared Major
@workflow/web Major
@workflow/cli Patch
@workflow/nitro Patch
workflow Patch
@workflow/world-testing Patch
@workflow/nuxt Patch
@workflow/core Patch
@workflow/builders Patch
@workflow/next Patch
@workflow/vitest Patch
@workflow/astro Patch
@workflow/nest Patch
@workflow/rollup Patch
@workflow/sveltekit Patch
@workflow/vite Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
example-nextjs-workflow-turbopack Ready Ready Preview Aug 3, 2026 7:54pm
example-nextjs-workflow-webpack Ready Ready Preview Aug 3, 2026 7:54pm
example-workflow Ready Ready Preview Aug 3, 2026 7:54pm
workbench-astro-workflow Ready Ready Preview Aug 3, 2026 7:54pm
workbench-express-workflow Ready Ready Preview Aug 3, 2026 7:54pm
workbench-fastify-workflow Ready Ready Preview Aug 3, 2026 7:54pm
workbench-hono-workflow Ready Ready Preview Aug 3, 2026 7:54pm
workbench-nestjs-workflow Ready Ready Preview Aug 3, 2026 7:54pm
workbench-nitro-workflow Ready Ready Preview Aug 3, 2026 7:54pm
workbench-nuxt-workflow Ready Ready Preview Aug 3, 2026 7:54pm
workbench-sveltekit-workflow Ready Ready Preview Aug 3, 2026 7:54pm
workbench-tanstack-start-workflow Ready Ready Preview Aug 3, 2026 7:54pm
workbench-vite-workflow Ready Ready Preview Aug 3, 2026 7:54pm
workflow-docs Ready Ready Preview, v0 Aug 3, 2026 7:54pm
workflow-swc-playground Ready Ready Preview Aug 3, 2026 7:54pm
workflow-tarballs Ready Ready Preview Aug 3, 2026 7:54pm
workflow-web Ready Ready Preview Aug 3, 2026 7:54pm
Move the directory, rename NewTraceViewer to TraceViewer across web-shared and web, and update the build script and README.

Signed-off-by: mitul-s <mitulxshah@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: Cursor Agent <cursoragent@cursor.com>
@mitul-s
mitul-s merged commit d06b55e into main Aug 3, 2026
57 checks passed
@mitul-s
mitul-s deleted the c-ms/rename-new-trace-viewer-to-trace-viewer branch August 3, 2026 20:34
@github-actions github-actions Bot mentioned this pull request Aug 3, 2026
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown
Contributor

No backport to stable for d06b55e (AI decision).

This is a pure rename/refactor: new-trace-viewer/trace-viewer/ and the public NewTraceViewer export → TraceViewer, with no bug fix or behavior correction. It carries a major changeset and is an intentional breaking API change for the next major, which is exactly what a maintenance branch should not receive.

To override, re-run the Backport to stable workflow manually via workflow_dispatch and paste this commit SHA into the ref input:

d06b55e64195d9e4b87521b8010967d16139cabc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants