Fix broken links

[aireilly]

* Fixed lychee errors and added /reference/speculators to .lycheeignore.
* Removed the auto-issue job, too noisy and not helpful
* Moved the link check job to run on PR CI jobs, not main nightly

Fix broken link errors.

Note, CI won't complete for PRs from forks, not sure if this is intended 🤷

[Copilot]

Pull Request Overview

This PR removes the automatic issue creation functionality from the link checker CI job while maintaining the link checking itself. The change simplifies the workflow by removing the step that automatically creates GitHub issues when broken links are detected.

• Removes the "Create Issues" step that automatically generates GitHub issues for link checker failures
• Maintains the link checking functionality and failure detection
• Keeps the manual failure step that exits with an error code when issues are found

Comments suppressed due to low confidence (1)

.github/workflows/main.yml:1

• The error message still references "the created issue" but no issue is being created anymore. This should be updated to reference checking the workflow logs or output instead.

name: Main

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[markurtz]

I'd like to keep the link checking CI on main/nightly. This is primarily because links on README.md or other places that need absolute references will not work until they are landed on main. Secondarily, adds one less job to wait on for PRs.

Towards the above, I think a nightly cadence would work best so we're not overloading main

[aireilly]

I'd like to keep the link checking CI on main/nightly. This is primarily because links on README.md or other places that need absolute references will not work until they are landed on main. Secondarily, adds one less job to wait on for PRs.

Towards the above, I think a nightly cadence would work best so we're not overloading main

Feel free to override or close this

[aireilly]

@markurtz I think this current approach is a good balance, depending on whether we want the build to fail on broken link errors or pass with warnings.

[fynnsu]

Offering this as an alternative to removing the nightly link checker.

Instead of opening a new issue each time, we just have a single issue which we add comments to.

[aireilly]

I'm going to stay in my lane on this one. This PR now just fixes some broken links.

[rahul-tuli]

LGTM! Thank you!