Skip to content

Minor update to allow hotfix for 0.4.0.1.#357

Merged
fynnsu merged 1 commit intorelease-0.4.0from
forhotfix
Mar 23, 2026
Merged

Minor update to allow hotfix for 0.4.0.1.#357
fynnsu merged 1 commit intorelease-0.4.0from
forhotfix

Conversation

@dhuangnm
Copy link
Copy Markdown
Collaborator

Minor update to allow hotfix for 0.4.0.1.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 23, 2026

📦 Build Artifacts Available
The build artifacts (`.whl` and `.tar.gz`) have been successfully generated and are available for download: https://github.com/vllm-project/speculators/actions/runs/23449974097/artifacts/6064120348.
They will be retained for up to 30 days.
Commit: ec76660

Signed-off-by: Dan Huang <dahuang@redhat.com>
Copy link
Copy Markdown
Collaborator

@fynnsu fynnsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this block tags with only three values?

Something like this

r"^v(\d+\.\d+\.\d+(\.\d+)?)$"

would allow us to match

either 3 or 4 component versions.
e.g.
v0.0.1 and v0.0.0.1

If we no longer need to match 3 component tags (since this is release branch only), lmk and I'll approve.

@dhuangnm
Copy link
Copy Markdown
Collaborator Author

Won't this block tags with only three values?

Something like this

r"^v(\d+\.\d+\.\d+(\.\d+)?)$"

would allow us to match

either 3 or 4 component versions. e.g. v0.0.1 and v0.0.0.1

If we no longer need to match 3 component tags (since this is release branch only), lmk and I'll approve.

This is a change for the release-0.4.0 branch for the hotfix 0.4.0.1. We'll only expect hotfixes from this branch. For main, we still keep the old way of versioning so 3 digits are still there for future releases.

@fynnsu fynnsu merged commit 3f75be5 into release-0.4.0 Mar 23, 2026
12 checks passed
@fynnsu fynnsu deleted the forhotfix branch March 23, 2026 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants