fix(types): normalized Query can have undefined properties#1510
Open
andresespinosapc wants to merge 1 commit intovuejs:mainfrom
Open
fix(types): normalized Query can have undefined properties#1510andresespinosapc wants to merge 1 commit intovuejs:mainfrom
andresespinosapc wants to merge 1 commit intovuejs:mainfrom
Conversation
When a query param is not present the query value is `undefined`, but the type is only `string | null`. Here is the extract of code where I had this problem: ``` const route = useRoute(); const sortBy = ref(route.query.sort_by.toString()) ``` I got `Cannot read property 'toString' of undefined` but the linter didn't give any errors.
✅ Deploy Preview for vue-router canceled.
|
posva
requested changes
Aug 10, 2022
Member
posva
left a comment
posva
left a comment
There was a problem hiding this comment.
Thanks, I think this would indeed be better. Can you add a d-ts test and make sure others pass?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a query param is not present the query value is
undefined, but the type is onlystring | null.Here is the extract of code where I had this problem:
I got
Cannot read property 'toString' of undefinedbut the linter didn't give any errors.