fix(store): return YAML error when parsing twurlrc - #54
Closed
braveocheretovych wants to merge 2 commits into
Closed
fix(store): return YAML error when parsing twurlrc#54braveocheretovych wants to merge 2 commits into
braveocheretovych wants to merge 2 commits into
Conversation
Signed-off-by: braveocheretovych <braveocheretovych@gmail.com>
santiagomed
requested changes
Apr 19, 2026
santiagomed
left a comment
santiagomed
left a comment
Collaborator
There was a problem hiding this comment.
Build fails: errors.NewYAMLError doesn't exist in the errors package. Either add a NewYAMLError function to errors/errors.go, or keep the existing NewJSONError call — both are deserialization errors and the distinction doesn't matter in practice.
Author
|
Added NewYAMLError and IsYAMLError in PR #65 |
Collaborator
|
@braveocheretovych can you just add the changes into one PR? Either this or the other one is fine |
Author
|
@santiagomed done! Merged the changes into #65. Closing this one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.