Skip to content

fix inconsistent effects for suspended nodes#3991

Draft
Madoshakalaka wants to merge 1 commit intomasterfrom
fix/suspense-use-effect-dom-ordering
Draft

fix inconsistent effects for suspended nodes#3991
Madoshakalaka wants to merge 1 commit intomasterfrom
fix/suspense-use-effect-dom-ordering

Conversation

@Madoshakalaka
Copy link
Member

@Madoshakalaka Madoshakalaka commented Feb 19, 2026

Description

Fixes #3780

Checklist

  • I have reviewed my own code
  • I have added tests
@github-actions
Copy link

github-actions bot commented Feb 19, 2026

Visit the preview URL for this PR (updated for commit c456a5f):

https://yew-rs-api--pr3991-fix-suspense-use-eff-egmiv6rd.web.app

(expires Thu, 26 Feb 2026 06:09:04 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@github-actions
Copy link

github-actions bot commented Feb 19, 2026

Benchmark - core

Yew Master

vnode           fastest       │ slowest       │ median        │ mean          │ samples │ iters
╰─ vnode_clone  2.672 ns      │ 2.852 ns      │ 2.679 ns      │ 2.683 ns      │ 100     │ 1000000000

Pull Request

vnode           fastest       │ slowest       │ median        │ mean          │ samples │ iters
╰─ vnode_clone  2.621 ns      │ 3.871 ns      │ 2.625 ns      │ 2.64 ns       │ 100     │ 1000000000

@github-actions
Copy link

github-actions bot commented Feb 19, 2026

Benchmark - SSR

Yew Master

Details
Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 302.549 303.020 302.785 0.128
Hello World 10 486.265 505.113 493.070 5.944
Function Router 10 1602.280 1623.570 1613.702 6.708
Concurrent Task 10 1005.025 1007.524 1006.610 0.807
Many Providers 10 1061.931 1094.512 1072.860 8.910

Pull Request

Details
Benchmark Round Min (ms) Max (ms) Mean (ms) Standard Deviation
Baseline 10 302.496 303.367 302.829 0.253
Hello World 10 499.629 511.519 503.286 3.590
Function Router 10 1606.224 1629.735 1616.873 7.856
Concurrent Task 10 1005.242 1007.754 1006.965 0.729
Many Providers 10 1047.319 1088.741 1057.677 12.308
@github-actions
Copy link

github-actions bot commented Feb 19, 2026

Size Comparison

Details
examples master (KB) pull request (KB) diff (KB) diff (%)
async_clock 96.833 96.839 +0.006 +0.006%
boids 165.479 165.492 +0.013 +0.008%
communication_child_to_parent 89.898 89.911 +0.013 +0.014%
communication_grandchild_with_grandparent 100.939 100.952 +0.013 +0.013%
communication_grandparent_to_grandchild 97.436 97.448 +0.013 +0.013%
communication_parent_to_child 87.314 87.327 +0.013 +0.015%
contexts 102.930 102.942 +0.013 +0.012%
counter 84.047 84.053 +0.006 +0.007%
counter_functional 85.393 85.398 +0.006 +0.007%
dyn_create_destroy_apps 87.123 87.136 +0.013 +0.015%
file_upload 96.572 96.578 +0.006 +0.006%
function_delayed_input 90.971 90.977 +0.006 +0.006%
function_memory_game 169.015 169.027 +0.013 +0.008%
function_router 326.375 326.388 +0.013 +0.004%
function_todomvc 160.920 160.933 +0.013 +0.008%
futures 232.377 232.383 +0.006 +0.003%
game_of_life 102.297 102.303 +0.006 +0.006%
immutable 244.699 244.712 +0.013 +0.005%
inner_html 78.628 78.634 +0.006 +0.007%
js_callback 107.431 107.443 +0.013 +0.012%
keyed_list 177.169 177.182 +0.013 +0.007%
mount_point 81.758 81.764 +0.006 +0.007%
nested_list 110.740 110.753 +0.013 +0.011%
node_refs 89.202 89.215 +0.013 +0.014%
password_strength 1726.270 1726.282 +0.013 +0.001%
portals 90.776 90.789 +0.013 +0.014%
router 297.119 297.132 +0.013 +0.004%
suspense 110.943 110.956 +0.013 +0.011%
timer 86.581 86.587 +0.006 +0.007%
timer_functional 96.105 96.118 +0.013 +0.013%
todomvc 139.516 139.521 +0.006 +0.004%
two_apps 83.909 83.915 +0.006 +0.007%
web_worker_fib 133.666 133.679 +0.013 +0.009%
web_worker_prime 184.621 184.634 +0.013 +0.007%
webgl 81.257 81.263 +0.006 +0.007%

✅ None of the examples has changed their size significantly.

@Madoshakalaka Madoshakalaka force-pushed the fix/suspense-use-effect-dom-ordering branch from 3bafe86 to c456a5f Compare February 19, 2026 06:06
@Madoshakalaka Madoshakalaka added the A-yew Area: The main yew crate label Feb 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-yew Area: The main yew crate

1 participant