ci: replace hand-maintained feature-soundness scripts with cargo-hack#4013
Open
Madoshakalaka wants to merge 1 commit intomasterfrom
Open
ci: replace hand-maintained feature-soundness scripts with cargo-hack#4013Madoshakalaka wants to merge 1 commit intomasterfrom
Madoshakalaka wants to merge 1 commit intomasterfrom
Conversation
|
Visit the preview URL for this PR (updated for commit 26462bf): https://yew-rs-api--pr4013-feat-cargo-hack-feat-3dhwlmdc.web.app (expires Fri, 06 Mar 2026 08:56:14 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Benchmark - coreYew MasterPull Request |
Size ComparisonDetails
✅ None of the examples has changed their size significantly. |
Member
Author
|
The feature soundness tests actually complete in 2 minutes, which is faster than documentation tests (3 mins), unit test (5 mins), and integration tests (5 mins), not mentioning SSR benchmarks (15+ minutes) so a full powerset with 7 times the invocation is not unrealistic. I don't oppose adding them too but they might not add much value. For reference
|
Benchmark - SSRYew MasterDetails
Pull RequestDetails
|
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
98 combinations from the full powerset might be unrealistic for CI
that's why there's
--exclude-features test,serde,not_browser_env. These features don't gate any code pathsThis then results in 14 clippy invocations are identical to what the old scripts ran, but now auto-discovered by cargo hack, so when features are added/removed, CI adapts automatically
--keep-goingadded so all failures are reported at onceFixes #2641
Checklist