Skip to content

Feature/parasha - #260

Open
elor555 wants to merge 88 commits into
PythonFreeCourse:developfrom
elor555:feature/parasha
Open

Feature/parasha#260
elor555 wants to merge 88 commits into
PythonFreeCourse:developfrom
elor555:feature/parasha

Conversation

@elor555

@elor555 elor555 commented Feb 11, 2021

Copy link
Copy Markdown

Create a new feature
In my feature, the parshas of the week are displayed every Saturday (on the dayview page).

Needs further treatment:

  • As part of the feature I have a link to a separate link (I set it to open a new pane). Is it problematic?
Comment thread app/database/models.py Outdated
Comment thread app/internal/json_data_loader.py
Comment thread app/internal/load_parasha.py Outdated
Comment thread app/internal/load_parasha.py Outdated
Comment thread app/internal/load_parasha.py Outdated
Comment thread app/resources/parashot.json Outdated
Comment thread app/routers/calendar.py Outdated
Comment thread app/routers/calendar.py Outdated
Comment thread app/routers/calendar.py Outdated
Comment thread app/routers/calendar_grid.py
Comment thread app/routers/calendar_grid.py Outdated
Comment thread app/routers/parasha.py Outdated
Comment thread tests/test_parasha.py Outdated
@ivarshav

Copy link
Copy Markdown
Contributor

Nice work!
Please fix flake 8 :)

@yammesicka yammesicka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great start! I've added some insights.

Comment thread app/templates/partials/calendar/monthly_view/add_week.html Outdated
Comment thread app/routers/calendar.py Outdated
Comment thread app/routers/calendar.py Outdated
@elor555
elor555 requested a review from yammesicka February 23, 2021 11:55

@yammesicka yammesicka left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, please review the insights I've added :)

Comment thread app/internal/json_data_loader.py Outdated
Comment thread app/internal/json_data_loader.py
Comment thread app/internal/weekly_parasha.py Outdated
Comment thread app/internal/weekly_parasha.py Outdated
Comment thread app/templates/calendar_day_view.html Outdated
Comment thread app/internal/weekly_parasha.py Outdated
Comment thread app/internal/json_data_loader.py
Comment thread app/internal/json_data_loader.py
Comment thread app/resources/parashot.json
Comment thread app/routers/calendar.py
Comment thread app/templates/calendar_day_view.html Outdated
Comment thread app/templates/calendar_day_view.html Outdated
Comment thread app/internal/weekly_parasha.py
Comment thread app/internal/weekly_parasha.py Outdated
Comment thread app/internal/weekly_parasha.py
Comment thread app/internal/weekly_parasha.py Outdated
Comment thread app/templates/calendar_day_view.html Outdated
Comment thread app/templates/calendar_day_view.html Outdated
Comment thread app/routers/dayview.py
Comment thread app/internal/json_data_loader.py Outdated
Comment thread app/templates/calendar_day_view.html Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants