add buffer package for use in browser#52
Closed
rvagg wants to merge 1 commit intobrowserify:masterfrom
Closed
Conversation
Contributor
|
I'm leaning more towards #53 since we have other cyrpto-browserify prackages that this one depends on that use safe-buffer so using it would add anything to the dependencies and until we can switch all of the crypto-browserify stuff to use the correct thing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #50
This is only used in the browser, Node.js will default to core buffer, so the main cost of this is the dependency weight, but it adds nice future proofing for the browser and Webpack.