fix: mains by format fallbacks - #964
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: a624894 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
rschristian
commented
May 19, 2022
| @@ -0,0 +1,10 @@ | |||
| { | |||
| "name": "custom-outputs", | |||
| "main": "dist/custom-outputs.js", | |||
Collaborator
Author
There was a problem hiding this comment.
This test doesn't actually test "main" correctly, as setting main creates a confusing mess of filenames (see #825 & #896).
"main": "dist/custom-outputs.cjsx.js" would make (say) the module output file path into dist/custom-outputs.cjsx.modulex.mjs. That is the "correct" output name at this time, but would be confusing as hell to debug as it doesn't match the package.json, so I've skipped it.
developit
approved these changes
May 20, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #963
Typo was from #950
We were missing tests for controlling the output filenames from
package.jsonnearly entirely, both the common fields ("main","module", etc.) and their alts ("cjs:main","esmodule", etc.). This adds a test suite for both (though there's still a few untested fields, like nested"exports"and"syntax.esmodule"entry).