Skip to content

fix(v8/angular): Fall back to element tagName when name is not provided to TraceDirective#14828

Merged
Lms24 merged 2 commits intov8from
lms/fix-angular-backport-14778
Dec 23, 2024
Merged

fix(v8/angular): Fall back to element tagName when name is not provided to TraceDirective#14828
Lms24 merged 2 commits intov8from
lms/fix-angular-backport-14778

Conversation

@Lms24
Copy link
Copy Markdown
Member

@Lms24 Lms24 commented Dec 23, 2024

Backport of #14778

…d to `TraceDirective` (#14778)

The `trace` directive should typically be declared on components to
validly trace the lifecycle (from `ngOnInit` to `ngAfterViewInit`, when
child views are also rendered). If `trace` is mistakenly not provided,
we fall back to `tagName` instead of "unknown component".

---------

Co-authored-by: Lukas Stracke <lukas.stracke@sentry.io>
@Lms24 Lms24 requested review from a team as code owners December 23, 2024 13:19
@Lms24 Lms24 changed the base branch from develop to v8 December 23, 2024 13:19
@Lms24 Lms24 self-assigned this Dec 23, 2024
@Lms24 Lms24 requested review from AbhiPrasad and chargome and removed request for a team December 23, 2024 13:20
@Lms24 Lms24 requested a review from andreiborza December 23, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants