Support packing Python 3.15 frozentdict (PEP 814) - #738
Open
edgarrmondragon wants to merge 1 commit into
Open
Conversation
edgarrmondragon
marked this pull request as ready for review
August 31, 2026 16:43
edgarrmondragon
force-pushed
the
frozendict
branch
from
August 31, 2026 16:54
5abaaad to
796acd2
Compare
Signed-off-by: Edgar Ramírez Mondragón <edgarrm358@gmail.com>
edgarrmondragon
force-pushed
the
frozendict
branch
from
August 31, 2026 16:59
796acd2 to
1106f89
Compare
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The hook test checks the input type instead of the unpacked result, leaving the documented behavior unverified.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds Python 3.15 frozendict packing support across both packer implementations.
Changes:
- Recognizes
frozendictas a MessagePack map. - Supports strict type handling.
- Adds packing and hook-based unpacking tests.
File summaries
| File | Description |
|---|---|
msgpack/fallback.py |
Adds fallback packer support. |
msgpack/_packer.pyx |
Adds C packer support. |
test/test_pack.py |
Tests frozendict round trips. |
Review details
- Files reviewed: 3/3 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| assert unpacked == fd | ||
|
|
||
| unpacked = unpackb(packb(fd), use_list=1, object_pairs_hook=builtins.frozendict) | ||
| assert isinstance(fd, builtins.frozendict) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support packing a Python 3.15
frozendict.This PR doesn't support unpacking into a
frozendictother than with the genericobject_pairs_hook=frozendict.