Skip to content

Fix ReactDOM prop ownership checks - #37419

Open
OskarEichler wants to merge 1 commit into
react:mainfrom
OskarEichler:fix/react-dom-safe-prop-property-checks
Open

Fix ReactDOM prop ownership checks#37419
OskarEichler wants to merge 1 commit into
react:mainfrom
OskarEichler:fix/react-dom-safe-prop-property-checks

Conversation

@OskarEichler

@OskarEichler OskarEichler commented Aug 30, 2026

Copy link
Copy Markdown

Summary

  • Use React's shared unbound hasOwnProperty helper for DOM prop iteration and hydration diagnostics.
  • Support props objects that shadow hasOwnProperty or do not inherit from Object.prototype.
  • Add regressions for custom-element mount/update and hydration diagnostics with a hasOwnProperty prop.

Breaking changes

None. Previously crashing or incomplete prop paths now use the normal ownership checks.

Verification

  • Full ReactDOMComponent and ReactDOMHydrationDiff suites: 206 tests passed, including 37 snapshots.
  • Changed-source linc, Prettier, and git diff --check passed.

Fixes #37415

@github-actions

github-actions Bot commented Aug 30, 2026

Copy link
Copy Markdown

A size report will appear here when the build finishes.

Generated by sizebot against 3109044

@meta-cla meta-cla Bot added the CLA Signed label Aug 30, 2026
@OskarEichler
OskarEichler force-pushed the fix/react-dom-safe-prop-property-checks branch from e1526fd to 3109044 Compare August 30, 2026 06:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

1 participant