Skip to content

[jsx] Warn when accessing an empty key prop - #37434

Open
OskarEichler wants to merge 1 commit into
react:mainfrom
OskarEichler:fix/react-empty-key-access-warning
Open

[jsx] Warn when accessing an empty key prop#37434
OskarEichler wants to merge 1 commit into
react:mainfrom
OskarEichler:fix/react-empty-key-access-warning

Conversation

@OskarEichler

@OskarEichler OskarEichler commented Aug 30, 2026

Copy link
Copy Markdown

Summary

Fixes #37433

Install React's development-only special-prop warning getter for empty keys ('').

Verification

  • Added test
@meta-cla meta-cla Bot added the CLA Signed label Aug 30, 2026
@github-actions

github-actions Bot commented Aug 30, 2026

Copy link
Copy Markdown

Comparing: 2dc7da7...baa1279

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 7.35 kB 7.35 kB = 1.96 kB 1.96 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 622.23 kB 622.23 kB = 110.01 kB 110.01 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 7.36 kB 7.36 kB = 1.96 kB 1.96 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 693.45 kB 693.45 kB = 121.46 kB 121.46 kB
facebook-www/ReactDOM-prod.classic.js = 713.62 kB 713.62 kB = 124.94 kB 124.94 kB
facebook-www/ReactDOM-prod.modern.js = 703.93 kB 703.93 kB = 123.36 kB 123.36 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by sizebot against baa1279

@eps1lon eps1lon changed the title Warn when accessing an empty React key prop Aug 31, 2026

@eps1lon eps1lon left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants