Fix:(issue_2293) --flag="" no longer rejected as missing argument - #2297
Merged
Merged
Conversation
dearchap
reviewed
Mar 25, 2026
dearchap
approved these changes
Mar 25, 2026
Maks1mS
pushed a commit
to stplr-dev/stplr
that referenced
this pull request
Mar 28, 2026
This PR contains the following updates: | Package | Type | Update | Change | OpenSSF | |---|---|---|---|---| | [github.com/urfave/cli/v3](https://github.com/urfave/cli) | require | minor | `v3.7.0` → `v3.8.0` | [](https://securityscorecards.dev/viewer/?uri=github.com/urfave/cli) | --- >⚠️ **Warning** > > Some dependencies could not be looked up. Check the [Dependency Dashboard](issues/23) for more information. --- ### Release Notes <details> <summary>urfave/cli (github.com/urfave/cli/v3)</summary> ### [`v3.8.0`](https://github.com/urfave/cli/releases/tag/v3.8.0) [Compare Source](urfave/cli@v3.7.0...v3.8.0) #### What's Changed - chore(deps): bump mkdocs-material from 9.7.1 to 9.7.2 in the python-packages group by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2267](urfave/cli#2267) - chore(deps): bump mkdocs-material from 9.7.2 to 9.7.3 in the python-packages group by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2272](urfave/cli#2272) - chore(deps): bump mkdocs-material from 9.7.3 to 9.7.4 in the python-packages group by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2276](urfave/cli#2276) - Fix: check MutuallyExclusiveFlags across parent command chain by [@​siutsin](https://github.com/siutsin) in [#​2274](urfave/cli#2274) - Modernize source code by [@​kolyshkin](https://github.com/kolyshkin) in [#​2289](urfave/cli#2289) - flag: replace regexp use by [@​kolyshkin](https://github.com/kolyshkin) in [#​2288](urfave/cli#2288) - chore(deps): bump mkdocs-material from 9.7.4 to 9.7.5 in the python-packages group by [@​dependabot](https://github.com/dependabot)\[bot] in [#​2284](urfave/cli#2284) - Fix:(issue\_2281) Remove incorrect check for local flag for set by [@​dearchap](https://github.com/dearchap) in [#​2290](urfave/cli#2290) - Fix:(issue\_2275) Make flag action execution consistent by [@​dearchap](https://github.com/dearchap) in [#​2295](urfave/cli#2295) - Fix:(issue\_2293) --flag="" no longer rejected as missing argument by [@​idelchi](https://github.com/idelchi) in [#​2297](urfave/cli#2297) - Fix:(issue\_2292) Empty positional args no longer break parse loop by [@​idelchi](https://github.com/idelchi) in [#​2296](urfave/cli#2296) #### New Contributors - [@​idelchi](https://github.com/idelchi) made their first contribution in [#​2297](urfave/cli#2297) **Full Changelog**: <urfave/cli@v3.7.0...v3.8.0> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At 12:00 AM through 04:59 AM and 10:00 PM through 11:59 PM, Monday through Friday ( * 0-4,22-23 * * 1-5 ), Only on Sunday and Saturday ( * * * * 0,6 ) (UTC), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My44Ni4xIiwidXBkYXRlZEluVmVyIjoiNDMuODYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiS2luZC9EZXBlbmRlbmNpZXMiXX0=--> Reviewed-on: https://altlinux.space/stapler/stplr/pulls/376 Co-authored-by: Renovate Bot <stapler-helper-bot@noreply.altlinux.space> Co-committed-by: Renovate Bot <stapler-helper-bot@noreply.altlinux.space>
This was referenced Apr 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
--flag=(explicit empty value via=) is rejected with "flag needs an argument" instead of setting the flag to an empty string. This is a side effect of #2223 where thevalFromEqualguard was made slightly too broad.Tightened the condition to
flagVal == "" && !valFromEqualso the "fetch next arg" block is skipped entirely when=was used. The #2223 fix is preserved — no arg consumption happens.Which issue(s) this PR fixes:
Fixes #2293
Testing
Added
TestFlagEqualsEmptyValuewith two subtests (sets empty string, does not consume next positional arg). Updated two existingTestFlagActionexpectations that encoded the broken behavior.Release Notes