Skip to main content
60 questions
Newest Active Bountied Unanswered
Best practices
2 votes
3 replies
65 views

I’m working on a project where we already use modern version control practices: Git with GitFlow branching Pull requests with mandatory reviews Conventional commit messages CI-based checks Despite ...
Sabbir MMS's user avatar
  • 1
0 votes
0 answers
150 views

Our team is working on a projects that involves multiple developers contributing to a repository on GitHub Enterprise. We'd like to implement a stricter approval process for pull requests targeting ...
vova25's user avatar
  • 1
6 votes
1 answer
3k views

When I am about to review a pull request on GitHub, I look at the lines of code changed to get an idea of how time-consuming the review will be. However, many projects include a bunch of generated ...
Joel Broström's user avatar
  • 4,230
3 votes
2 answers
8k views

I approved a PR, and see: "approved these changes now" but then right below that I still see: "At least 1 approving review is required by reviewers with write access." I went to ...
Jason D.'s user avatar
  • 490
2 votes
0 answers
908 views

The problem I noticed that no one except the GitHub repo owner (me) can see a code review. Example PRs: 1 2 On the first screenshot is what I can see (the PR review started), and next (second ...
sunnamed's user avatar
  • 260
1 vote
2 answers
765 views

My question may seem dumb, but I couldn't find a proper answer for it after searching for a while. Imagine we have an enum called MissionStateEnum as below(since I am a c# developer I'm writing my ...
Amirmahdi Ghodsi's user avatar
  • 107
0 votes
2 answers
4k views

In a GitHub Action. From all of the reviewers of a pull request The people who have approved said pull request I want to get their username. I am expecting there is a value I can pass to a "step&...
Liam Pillay's user avatar
  • 859
4 votes
0 answers
248 views

I'm converting quite a lot of code from JavaScript to TypeScript, which means: rename files from .js to .ts add type annotations etc Of course in many cases, such a refactoring can be substantial, ...
JHH's user avatar
  • 9,425
0 votes
1 answer
185 views

I'm using PullApprove v3 for GitHub PRs. I have a larger team general-team and a smaller team specific-team. specific-team is a subset of general-team. I want to allow PR approvals from anyone on ...
savagedata's user avatar
  • 730
2 votes
1 answer
552 views

In Bitbucket, on any Pull Request, reviews are disabled after the PR is merged. I'd like to continue to allow reviews after a PR is merged. Is this possible? NOTE: I am not asking about requiring ...
Peter H. Boling's user avatar
  • 581
0 votes
1 answer
205 views

I have a pull request that makes changes to multiple files and codeowners of those files are different. Example: File_1 has codeowners X,Y,Z File_2 has codeowners A,B Initially X,Y and Z approved the ...
akash deep's user avatar
  • 167
2 votes
2 answers
3k views

Our github repo includes a directory containing language translation files. These are generated automatically from a database. Ideally we should find a way to deploy these through some other mechanism ...
Barmar's user avatar
  • 791k
0 votes
1 answer
151 views

I'm use to using Crucible on code reviews, but we started using Github pull-request. I've created a pull-request and now completed the changes suggested by one of the code reviewers. What I did was I ...
Reydan Gatchalian's user avatar
  • 321
0 votes
1 answer
181 views

I'm following this recipe: https://thib.me/recipe-code-reviews-for-existing-code-with-github. In the interactive rebase step, I'm adding a pick line for the empty commit created in review-1-target ...
Peteris's user avatar
  • 3,786
1 vote
0 answers
194 views

I am used to document code reviews using a software called collaborator (https://smartbear.com/product/collaborator/overview/) Is there there any way we can create similar reports from GitHub pull ...
cricardol's user avatar
  • 4,222

15 30 50 per page
1
2 3 4