Comparing data from two data tables

Question

I have this code which compares data from two data tables. It does this by using a primary column and inserting the new record from table2 to table1. This loop continues for a large number of tables. I want to optimize it. Kindly give suggestions.

foreach (DataRow drRow in table2.Rows)
{
    if(!table1.Rows.Contains(drRow["KeyId"]))
    {
        table1.ImportRow(drRow);
    }
}

I think that this might be the best way to do it. I have done a little bit of looking and it seems like the other ways that I have thought about doing it fall short of this code. — Malachi
– Malachi, Commented Oct 25, 2013 at 13:50
Malachi, thanks a lot for looking into it. I too trying to find other way which will be more optimized. — rrk
– rrk, Commented Oct 28, 2013 at 4:39

Purnil Soni · Accepted Answer · 2013-10-29 05:59:49Z

1

For .net framework 3.5, you can have following code improvements:

foreach (var drRow in table2.Rows.Cast<DataRow>()
                      .Where(drRow => !table1.Rows.Contains(drRow["KeyId"]))) 
{
    table1.ImportRow(drRow); 
}

part of body can be converted to LINQ-expression
use "var" (implicitly typed) instead of "DataRow" (explicitly typed)

answered Oct 29, 2013 at 5:59

Purnil Soni

1262 bronze badges

\$\begingroup\$ Hi Purnil,I tried and i was not able to see any improvement in performance. In fact the old code was faster. Anyways thanks for your inputs :) \$\endgroup\$

rrk
– rrk

2013-10-31 06:19:32 +00:00
Commented Oct 31, 2013 at 6:19

Add a comment |

Stack Exchange Network

Comparing data from two data tables

1 Answer 1

You must log in to answer this question.

Hot Network Questions

Comparing data from two data tables

1 Answer 1

You must log in to answer this question.

Related

Hot Network Questions