Using GeoComplete with RequireJS (with shim config)

Question

I am using the GeoComplete plugin with RequireJS It works, but please could someone confirm I've done this correctly, mainly my understanding of shim:

    requirejs.config({
        waitSeconds: 120,
        paths: {
            async: './lib/async',
            jquery: './lib/jquery-1.7.2.min',
            geocomplete: './lib/jquery.geocomplete.min'
        },
        shim: {
            'geocomplete': ['jquery'],
        }
    });

    require(['async!http://maps.googleapis.com/maps/api/js?libraries=places&sensor=false', 'jquery', 'geocomplete'], function () {
        $("#geocomplete").geocomplete({
            map: "#map_canvas"
        });
    }
    );

The way I understand shim, is, GeoComplete doesn't support AMD, but has a dependency on jQuery, so my set up basically says "load geocomplete after jquery"

Is that correct?

Does it work as you expected? If it does, you have probably done it correctly :) — Simon Forsberg
– Simon Forsberg, Commented Feb 25, 2014 at 15:41
haha, yes, it does.... was just very new to requirejs, and hadn't quite got my head around the idea of the shim. Think I get it now! — Alex
– Alex, Commented Feb 25, 2014 at 15:42

Jamal · Accepted Answer · 2014-02-25 17:42:31Z

5

The only thing that I see looking at this code is that you didn't keep a fully consistent formatting, and I at first thought you had an extra set of brackets or parentheses.

enter image description here

You should do it like the }); farther above in the code.

Keep everything consistent, you probably already know this though.

edited Feb 25, 2014 at 17:42

Jamal

35.2k13 gold badges134 silver badges238 bronze badges

answered Feb 25, 2014 at 15:44

Malachi

29.1k11 gold badges87 silver badges188 bronze badges

1

\$\begingroup\$ I agree, and I usually have code-ocd when it comes to this! \$\endgroup\$

Alex
– Alex

2014-02-25 16:03:12 +00:00
Commented Feb 25, 2014 at 16:03

Add a comment |

Stack Exchange Network

Using GeoComplete with RequireJS (with shim config)

1 Answer 1

You must log in to answer this question.

Hot Network Questions

Using GeoComplete with RequireJS (with shim config)

1 Answer 1

You must log in to answer this question.

Related

Hot Network Questions