Re: com php-src: Fix bug #66015 by reverting "Removed operations on constant arrays.": Zend/tests/bug66015.phpt Zend/tests/errmsg_040.phpt
Zend/tests/ns_059.phpt Zend/zend.h Zend/zend_API.c Zend/zend_ast.c Zend/zend_ast.h Zend/zend_compile.c Zend...

From: Date: Sun, 13 Apr 2014 08:15:55 +0000
Subject: Re: com php-src: Fix bug #66015 by reverting "Removed operations on constant arrays.": Zend/tests/bug66015.phpt Zend/tests/errmsg_040.phpt
Zend/tests/ns_059.phpt Zend/zend.h Zend/zend_API.c Zend/zend_ast.c Zend/zend_ast.h Zend/zend_compile.c Zend...
References: 1 2 3  Groups: php.cvs 
Request: Send a blank email to php-cvs+get-76813@lists.php.net to get a copy of this message 
2014.04.13. 9:55, "Nikita Popov" <nikita.ppv@gmail.com> ezt írta:
>
> On Sun, Apr 13, 2014 at 8:59 AM, Stas Malyshev <smalyshev@sugarcrm.com>
wrote:
>>
>> Hi!
>>
>> > Commit:    f614fc68984b2d7fce3f275b8106955b5d910472
>> > Author:    Bob Weinand <bobwei9@hotmail.com>         Fri, 11 Apr 2014
10:06:17 +0200
>> > Parents:   d3f390a26888eefd012b4634137318797965ea86
>> > Branches:  PHP-5.6
>> >
>> > Link:
http://git.php.net/?p=php-src.git;a=commitdiff;h=f614fc68984b2d7fce3f275b8106955b5d910472
>> >
>> > Log:
>> > Fix bug #66015 by reverting "Removed operations on constant arrays."
>>
>> Could you explain this patch? This seems to introduce different behavior
>> in 5.6 than we previously had, which may be a serious BC break if
>> somebody has such code somewhere. Prior to 5.6, second and third has
>> indexes of 0 and 1, with your patch they have indexes of 1 and 2, which
>> is different.
>
>
> This change fixes a bug in the constant updating functionality, by
bringing the behavior of static scalar arrays in line with normal arrays.
This means that
>
>     static $a = [FOO => 1, 2, 3];
>
> and
>
>     $a = [FOO => 1, 2, 3];
>
> will now exhibit the same behavior.
>
> I don't see how this particular bug fix is any more a BC break than any
other bug fix.
>
> Nikita

And the reverted commit is 5.6 only from Bob himself, so I'm fine with the
change.

Thread (9 messages)

« previous php.cvs (#76813) next »