Re: com php-src: Fix bug #66015 by reverting "Removed operations on constant arrays.": Zend/tests/bug66015.phpt Zend/tests/errmsg_040.phpt
Zend/tests/ns_059.phpt Zend/zend.h Zend/zend_API.c Zend/zend_ast.c Zend/zend_ast.h Zend/zend_compile.c ...

From: Date: Sun, 13 Apr 2014 08:45:50 +0000
Subject: Re: com php-src: Fix bug #66015 by reverting "Removed operations on constant arrays.": Zend/tests/bug66015.phpt Zend/tests/errmsg_040.phpt
Zend/tests/ns_059.phpt Zend/zend.h Zend/zend_API.c Zend/zend_ast.c Zend/zend_ast.h Zend/zend_compile.c ...
References: 1 2 3 4  Groups: php.cvs 
Request: Send a blank email to php-cvs+get-76816@lists.php.net to get a copy of this message 
On Sun, Apr 13, 2014 at 10:23 AM, Stas Malyshev <smalyshev@sugarcrm.com>wrote:

> Hi!
>
> > This change fixes a bug in the constant updating functionality, by
> > bringing the behavior of static scalar arrays in line with normal
> > arrays.
>
> At the very least it should have a prominent note in UPGRADING. Changing
> behavior of arrays in classes that existed for whole 5.x line (even if
> it's a desired change) is not a small bugfix that should be done without
> notice. It will change behavior of the code, and may lead to some very
> hard to find bugs after upgrade.
>
> --
> Stanislav Malyshev, Software Architect
> SugarCRM: http://www.sugarcrm.com/
> (408)454-6900 ext. 227
>


Stas, did you get my previous change?
The reverted change was introduced in php 5.6, so I don't think we have to
mention anything in the UPGRADING.
Am I missing something?

-- 
Ferenc Kovács
@Tyr43l - http://tyrael.hu

Thread (9 messages)

« previous php.cvs (#76816) next »