Re: com php-src: Fix bug #67064 in a BC safe way You can use an optional parameter now when implementing the Countable interface to get the $mode
passed to count().: ext/standard/array.c ext/standard/tests/array/bug67064.phpt

From: Date: Sun, 13 Apr 2014 20:32:49 +0000
Subject: Re: com php-src: Fix bug #67064 in a BC safe way You can use an optional parameter now when implementing the Countable interface to get the $mode
passed to count().: ext/standard/array.c ext/standard/tests/array/bug67064.phpt
References: 1 2 3  Groups: php.cvs 
Request: Send a blank email to php-cvs+get-76833@lists.php.net to get a copy of this message 
Hi!

> an API change. The interface hasn't changed.

It has. Formerly, you did not have a parameter supplied for this
function, starting with next version, you do. If you write code that
implements this function, you need to know it changed.

Also, this change seems to break a lot of tests, see:
https://travis-ci.org/php/php-src/builds/22895161

Looks like it is not as BC safe as it was intended. Please fix it or
revert the change - BC break in 5.4 is not acceptable.

> It'd only be an API change if it forced the user to change its declaration.

Not true. For example, we document new functions in UPGRADING, even
though adding new functions does not force anybody to change anything.
Same with new parameter to existing functions - see for example "Changes
to existing functions" section.

> I'll add some documentation about that.

Thank you.


-- 
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227

Thread (10 messages)

« previous php.cvs (#76833) next »