Re: com php-src: Fix bug #67064 in a BC safe way You can use an optional parameter now when implementing the Countable interface to get the $mode
passed to count().: ext/standard/array.c ext/standard/tests/array/bug67064.phpt

From: Date: Sun, 13 Apr 2014 20:40:14 +0000
Subject: Re: com php-src: Fix bug #67064 in a BC safe way You can use an optional parameter now when implementing the Countable interface to get the $mode
passed to count().: ext/standard/array.c ext/standard/tests/array/bug67064.phpt
References: 1 2 3 4  Groups: php.cvs 
Request: Send a blank email to php-cvs+get-76834@lists.php.net to get a copy of this message 
Hi!

> Also, this change seems to break a lot of tests, see:
> https://travis-ci.org/php/php-src/builds/22895161
> 
> Looks like it is not as BC safe as it was intended. Please fix it or
> revert the change - BC break in 5.4 is not acceptable.

Looking at it again, I don't think we can put this patch in either 5.4
or 5.5. It changes extension API and breaks any module that implements
Countable because most of them expect 0 params and will produce warning
if given one param. Right now it broke Phar and SplObserver, but
third-party modules will have the same issue. Unless you find a way to
fix this in a generic way, we can only do it in 5.6, and even that only
with permission from Ferenc, since we're in the freeze now. In any case,
this means UPGRADING and probably UPGRADING.INTERNALS note is absolutely
necessary, as every extension having Countable classes will need to be
fixed.

This is, BTW, why we should have RFC and pull request before committing
such changes.
-- 
Stanislav Malyshev, Software Architect
SugarCRM: http://www.sugarcrm.com/
(408)454-6900 ext. 227

Thread (10 messages)

« previous php.cvs (#76834) next »