Re: com php-src: fix for phpng, failing RFC2144 test: ext/mcrypt/mcrypt.c ext/mcrypt/mcrypt_filter.c
it's an instruction to build release build for benchmark.
I don't think core developers need any instruction, but it make sense to
mention that tests should be checked in DEBUG build and then even with
valgrind (e.g. make test TESTS="-m ext/ftp)
Thanks. Dmitry.
On Tue, May 6, 2014 at 2:24 PM, Joe Watkins <pthreads@pthreads.org> wrote:
> On Tue, 2014-05-06 at 13:49 +0400, Dmitry Stogov wrote:
> > Fast work :)
> >
> > However, it seems like many tests are failed because of memory
> > leak(s).
> >
> > Try rum make test TESTS=ext/mcrypt on DEBUG PHP build
> >
> > It must be something simple, but I didn't try to look yet.
> >
> >
> > Thanks. Dmitry.
> >
> > FAILED TEST SUMMARY
> > ---------------------------------------------------------------------
> > Bug #43143 (Warning about empty IV with MCRYPT_MODE_ECB)
> > [ext/mcrypt/tests/bug43143.phpt]
> > Bug #46010 (warnings incorrectly generated for iv in ecb mode)
> > [ext/mcrypt/tests/bug46010.phpt]
> > mcrypt_create_iv https://bugs.php.net/bug.php?id=55169
> > [ext/mcrypt/tests/bug55169.phpt]
> > RFC 2144 test vectors for CAST-128 in ECB mode (bug #62102)
> > [ext/mcrypt/tests/bug62102_rfc2144.phpt]
> > mcrypt_cbc [ext/mcrypt/tests/mcrypt_cbc.phpt]
> > Test mcrypt_cbc() function : basic functionality
> > [ext/mcrypt/tests/mcrypt_cbc_3des_decrypt.phpt]
> > Test mcrypt_cbc() function : basic functionality
> > [ext/mcrypt/tests/mcrypt_cbc_3des_encrypt.phpt]
> > Test mcrypt_cbc() function : usage variation
> > [ext/mcrypt/tests/mcrypt_cbc_variation3.phpt]
> > Test mcrypt_cbc() function : usage variation
> > [ext/mcrypt/tests/mcrypt_cbc_variation4.phpt]
> > mcrypt_cfb [ext/mcrypt/tests/mcrypt_cfb.phpt]
> > mcrypt_create_iv [ext/mcrypt/tests/mcrypt_create_iv.phpt]
> > mcrypt_decrypt [ext/mcrypt/tests/mcrypt_decrypt.phpt]
> > Test mcrypt_decrypt() function : basic functionality
> > [ext/mcrypt/tests/mcrypt_decrypt_3des_cbc.phpt]
> > Test mcrypt_decrypt() function : basic functionality
> > [ext/mcrypt/tests/mcrypt_decrypt_3des_ecb.phpt]
> > Test mcrypt_decrypt() function : usage variation
> > [ext/mcrypt/tests/mcrypt_decrypt_variation3.phpt]
> > mcrypt_ecb [ext/mcrypt/tests/mcrypt_ecb.phpt]
> > Test mcrypt_cbc() function : basic functionality
> > [ext/mcrypt/tests/mcrypt_ecb_3des_decrypt.phpt]
> > Test mcrypt_ecb() function : basic functionality
> > [ext/mcrypt/tests/mcrypt_ecb_3des_encrypt.phpt]
> > Test mcrypt_ecb() function : usage variation
> > [ext/mcrypt/tests/mcrypt_ecb_variation3.phpt]
> > Test mcrypt_ecb() function : usage variation
> > [ext/mcrypt/tests/mcrypt_ecb_variation4.phpt]
> > Test mcrypt_ecb() function : usage variation
> > [ext/mcrypt/tests/mcrypt_ecb_variation5.phpt]
> > Test mcrypt_encrypt() function : TripleDES functionality
> > [ext/mcrypt/tests/mcrypt_encrypt_3des_cbc.phpt]
> > Test mcrypt_encrypt() function : TripleDES functionality
> > [ext/mcrypt/tests/mcrypt_encrypt_3des_ecb.phpt]
> > Test mcrypt_encrypt() function : usage variation
> > [ext/mcrypt/tests/mcrypt_encrypt_variation3.phpt]
> > mcrypt_ofb [ext/mcrypt/tests/mcrypt_ofb.phpt]
> > Test mcrypt_encrypt() function : AES functionality
> > [ext/mcrypt/tests/mcrypt_rijndael128_128BitKey.phpt]
> > Test mcrypt_encrypt() function : AES functionality
> > [ext/mcrypt/tests/mcrypt_rijndael128_256BitKey.phpt]
> > =====================================================================
> >
> >
> >
> >
> > On Tue, May 6, 2014 at 12:08 PM, Joe Watkins <krakjoe@php.net> wrote:
> > Commit: 4187be99fe1cfd6c66f30f2c23bf1ba2c2f425e1
> > Author: krakjoe <joe.watkins@live.co.uk> Tue, 6 May
> > 2014 09:08:02 +0100
> > Parents: 362e1db428c08f4ff8cac3b059b36013c398fada
> > Branches: phpng
> >
> > Link:
> >
> http://git.php.net/?p=php-src.git;a=commitdiff;h=4187be99fe1cfd6c66f30f2c23bf1ba2c2f425e1
> >
> > Log:
> > fix for phpng, failing RFC2144 test
> >
> > Changed paths:
> > M ext/mcrypt/mcrypt.c
> > M ext/mcrypt/mcrypt_filter.c
> >
> >
> > --
> > PHP CVS Mailing List (http://www.php.net/)
> > To unsubscribe, visit: http://www.php.net/unsub.php
> >
> >
>
> Woops ... fixed
>
> Might be an idea to change the build instructions on wiki to include
> --enable-debug, so that lazy people who copypasta get a debug build ...
>
> Cheers
> Joe
>
>
Thread (8 messages)