Re: com php-src: fix for phpng, failing RFC2144 test: ext/mcrypt/mcrypt.c ext/mcrypt/mcrypt_filter.c

From: Date: Tue, 06 May 2014 14:40:35 +0000
Subject: Re: com php-src: fix for phpng, failing RFC2144 test: ext/mcrypt/mcrypt.c ext/mcrypt/mcrypt_filter.c
References: 1 2 3 4  Groups: php.cvs 
Request: Send a blank email to php-cvs+get-78141@lists.php.net to get a copy of this message 
On Tue, 2014-05-06 at 15:31 +0400, Dmitry Stogov wrote:
> 
> 
> 
> On Tue, May 6, 2014 at 2:30 PM, Joe Watkins <pthreads@pthreads.org>
> wrote:
>         Also, all the char *, int, everywhere for strings feels really
>         messy
>         now ... I'll go back over what I've changed when zpp has a
>         zend_string*
>         type specifier ...
> 
> 
> Use "S" to receive zend_string*.
> 
>  
>         
>         php_mcrypt_do_crypt(char* cipher, const char *key, int
>         key_len, const
>         char *data, int data_len, char *mode, const char *iv, int
>         iv_len, int
>         dencrypt, zval* return_value TSRMLS_DC)
>         
>         Suddenly, really really messy ...
> 
> does that last failed test work on "master"?
> 
> 
> Thanks. Dmitry.
> 
>  
> 
>         
>         Cheers
>         Joe

Just confirmed, that test does fail on master, yes ...

I tried a quick refactor to use S but got unexpected results, will come
back to it.

For now, mcrypt done ;)

Cheers
Joe

Thread (8 messages)

« previous php.cvs (#78141) next »