Re: [PATCH] Raise warning first on "Maximum execution time exceeded"

From: Date: Mon, 22 Mar 2010 17:55:00 +0000
Subject: Re: [PATCH] Raise warning first on "Maximum execution time exceeded"
References: 1 2 3 4 5  Groups: php.internals 
Request: Send a blank email to internals+get-47464@lists.php.net to get a copy of this message
On Mon, Mar 22, 2010 at 4:55 PM, troels knak-nielsen <troelskn@gmail.com> wrote:
> On Mon, Mar 22, 2010 at 4:41 PM, Herman Radtke <hermanradtke@gmail.com> wrote:
>>> What do you mean by "no option"? Otherwise yes, that's what it does.
>> Using sleep there is not a good practice.  Since the custom error
>> handler is triggered, there is no need for the sleep call anyways.
>
> So control isn't returned to the C-code before the php error handler
> finishes. Is that it?

Just checked, and you're right about this. I've made a new patch,
which addresses this. Again, I have no idea about whether I'm
violating code style (Should zend_timeout_softswitch be declared or
named differently?), so comments on that please?

New patch attached - disregard the previous one.

-- 
troels


Attachment: [text/x-diff] zend_timeout_warning_2.patch

Thread (26 messages)

« previous php.internals (#47464) next »