Re: [PATCH] Raise warning first on "Maximum execution time exceeded"

From: Date: Tue, 23 Mar 2010 09:50:15 +0000
Subject: Re: [PATCH] Raise warning first on "Maximum execution time exceeded"
References: 1 2 3 4 5 6 7 8 9 10  Groups: php.internals 
Request: Send a blank email to internals+get-47475@lists.php.net to get a copy of this message
Hi Stan.

On Tue, Mar 23, 2010 at 8:47 AM, Stan Vassilev <sv_forums@fmethod.com> wrote:
> Thanks for your patch, but you're going to affect a whole group of users who
> do advanced logging and recovery in the shutdown phase. This is why these
> things have to be considered when they're first added.

How would they be affected? Current behavior would still be there.

> A grace period of 1 second seems sufficient on a pristine condition unused
> server, but when your server is loaded, a spike in load may cause a number
> of shutdown handlers to take more than 1 second, and stop middway running,
> causing a lot of unpredictability and trouble for those who rely on this
> feature.

So, you mean that a patch that fixes 90% of the cases, but leaves the
10%, is worse than no patch, because of the confusion it might cause?

I guess that could be a valid point; Is it a generally agreed-on
strategy for php?

-- 
troels


Thread (26 messages)

« previous php.internals (#47475) next »