Re: func_get_args BC break
I'm completely disagree.
That PHP code (in bug report) worked not by design.
Actually, it's wrong code that worked just because of luck (zval refcount
became 1).
I don't see any reason to keep such compatibility for 5.6 in cost of
performance.
Thanks. Dmitry.
On Mon, Dec 9, 2013 at 12:31 PM, Ferenc Kovacs <tyra3l@gmail.com> wrote:
>
>
>
> On Mon, Dec 9, 2013 at 7:45 AM, Dmitry Stogov <dmitry@zend.com> wrote:
>
>> Hi,
>>
>> I agree that the change makes BC break for some tricky code :(
>> and i don't insist to keep it in 5.5.
>>
>> Thanks. Dmitry.
>>
>>
>>
>>
>> On Mon, Dec 9, 2013 at 4:26 AM, Stas Malyshev <smalyshev@sugarcrm.com
>> >wrote:
>>
>> > Hi!
>> >
>> > Can we do anything to fix it? Is the problem limited only to
>> > pass-object-by-ref or also for other by-ref scenarios? In the latter
>> > case it does constitute a BC break I think and it may be a good idea to
>> > move it to 5.6...
>> >
>> >
>>
>
> Hi,
>
> as we agreed that this is a BC break, I don't think that it is a good idea
> even for 5.6.
> could we also create a test for this behavior, so we don't change this
> unintentionally later on?
>
>
> --
> Ferenc Kovács
> @Tyr43l - http://tyrael.hu
>
Thread (5 messages)