Re: TSRMLS_FETCH crusade
On Tue, 31 Dec 2013, Mike wrote:
> On Wed, 2013-12-18 at 13:30 +0000, Joe Watkins wrote:
> > On 12/18/2013 01:06 PM, Derick Rethans wrote:
> > > On Wed, 18 Dec 2013, Mike wrote:
> > >
> > >>> # Affected extensions have all been updated, ext/opcache and
> > >>> ext/zip # both have macros for cross version compatibility
> > >>
> > >> What's with all the other extensions? PECL or wild? That
> > >> TSRMLS_FETCH crusade seems pretty worthless as long as it is
> > >> found in _emalloc etc.
> > >
> > > A much nicer thing would be to just get rid of TS and TSRMLS in
> > > the first place across the board.
> >
> > If you mean having to pass it around or fetch it, I agree ...
No, not what I meant. I meant getting rid of TSRM all together.
> > There is a patch for native tls, it has a mode where TSRMLS_anything
> > is removed completely, no has no function but doesn't break anything
> > (empty define), a couple of months ago we had it working with master
> > ...
> >
> > Big job, intend to do it one day ...
>
> So... anything to add here? I saw Sara doing the first PECL extension
> adjustments for PHP-5.7 and I already dislike the ifdefs coming...
So what sort of changes do need to be made in extensions?!
cheers,
Derick
Thread (9 messages)