Trouble writing php variables into javascript

Question

 'success'=>'js: function(data) {
        $("#addToListDialog$model->product_id").dialog().dialog("close");}'

I'm trying to write the above piece of javascript, but can't get the right combination of curly brackets a single/double quotes in order to resolve the PHP variable. How should I be writing this?

Try wrapping your PHP variable in curly braces: {$model->product_id} — andrewsi
– andrewsi, Commented May 15, 2013 at 19:59
You shouldn't be building JavaScript with PHP. It's A Bad Idea™. Keep your HTML in .html files, your CSS in .css files, and your JS in .js files. Use [data-*] attributes and classes if you need to pass data to JavaScript. — zzzzBov
– zzzzBov, Commented May 15, 2013 at 20:00
why are you closing the dialog as soon as you create it. if you don't want it auto opened then just use _id').dialog({ autoOpen: false }) — SpYk3HH
– SpYk3HH, Commented May 15, 2013 at 20:13

MarZab · Accepted Answer · 2013-05-15 20:00:27Z

3

A cleaner way:

'success'=>'js: function(data) {
        $("#addToListDialog'.$model->product_id.'").dialog().dialog("close");}'

answered May 15, 2013 at 20:00

MarZab

2,67823 silver badges29 bronze badges

Sign up to request clarification or add additional context in comments.

10 Comments

thaJeztah Over a year ago

I prefer this approach as it is cleared that the string contains a PHP variable. Embedding variables inside strings is easy to overlook, which makes it hard to debug. Also, when refactoring (e.g. Rename $model to $somethingElse), most IDEs will not rename the variable if it is within a string.

SpYk3HH Over a year ago

@thaJeztah One IDE will ... Komodo :P

MarZab Over a year ago

and most that do have color coding so you cant miss the variables inside blocks of text. its about the escaping really ;)

Kevin Somers-Higgins Over a year ago

@MarZab I agree, in this case it's more convenient. Here is a discussion on the subject stackoverflow.com/questions/5605965/…

thaJeztah Over a year ago

@SpYk3HH Maybe should have left out 'most' LOL, my IDE does it as well, but I've had situations where an IDE didn't properly pick up the variable

|

Kevin Somers-Higgins · Accepted Answer · 2013-05-15 20:00:52Z

1

Your PHP string must be in double quotations.

This should do the trick:

'success'=>"js: function(data) {
        $(\"#addToListDialog{$model->product_id}\").dialog().dialog(\"close\");}"

edited May 15, 2013 at 20:00

answered May 15, 2013 at 19:59

Kevin Somers-Higgins

1,0051 gold badge11 silver badges13 bronze badges

Collectives™ on Stack Overflow

Trouble writing php variables into javascript

2 Answers 2

10 Comments

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

10 Comments

Comments

Linked

Related