jquery check if query string returned null

Question

I need to check the values of an empty querystring but I'm doing something wrong :( When the url is index.php for exemple I need it to open the #home but if it is index.php?m=1&s=1 it open #page_1_1

    function getUrlVars()
{
    var vars = [], hash;
    var hashes = window.location.href.slice(window.location.href.indexOf('?') + 1).split('&');
    for(var i = 0; i < hashes.length; i++)
    {
        hash = hashes[i].split('=');
        vars.push(hash[0]);
        vars[hash[0]] = hash[1];
    }
    return vars;
}
var m = getUrlVars()["m"];
var s = getUrlVars()["s"];

if((m!='')&&(s!='')){
    $('#page_'+m+'_'+s+'').show();
}
    else{ $('#home').show(); }

what is the problem?, alert(m), alert(s), what value are showing? — Emilio Gort
– Emilio Gort, Commented Oct 31, 2013 at 2:40
I dont know what the function get when is an empty querystring, I've tried '', '0', null but it's not working — BrunoWB
– BrunoWB, Commented Oct 31, 2013 at 2:43
check where u are using vars[hash[0]]=hash[1], because hash[0] is 'm' and hash[1] is '1&s' — user2897690
– user2897690, Commented Oct 31, 2013 at 2:52

Kevin Babcock · Accepted Answer · 2013-10-31 02:47:50Z

1

m & s will be undefined if the query string is empty or does not contain those values. You need to change your check to the following:

if(m && s) {
    $('#page_'+m+'_'+s+'').show();
} else {
    $('#home').show();
}

The if statement above will evaluate to false if m or s are omitted from the query string, or if either of them are empty (e.g. http://www.somewhere.com?m=1&s=)

answered Oct 31, 2013 at 2:47

Kevin Babcock

10.2k20 gold badges72 silver badges90 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Wagner DosAnjos Over a year ago

Note that the test will fail if m or s is an empty string on the url, because if('') evaluates to false. This might not apply to your case, but it's worth mentioning.

Collectives™ on Stack Overflow

jquery check if query string returned null

1 Answer 1

1 Comment

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Related