Display javascript variable in html

Question

I'm trying to display a variable with this code:

HTML:

<div id="MyEdit">Money</div>

JS:

var price1 = 0;
var current_value=document.getElementById("MyEdit").innerHTML;

if (current_value == "msc" or current_value == "phd") {
    price1 = 150;
}
else {
    price1 = 250;
}

document.getElementById("MyEdit").innerHTML = price1;

Any tips as to what I am doing wrong?

It's a var now, and the guy who answered told me to open a new one if it did not do what I needed. :P — Coolcrab
– Coolcrab, Commented Feb 10, 2014 at 21:23
is the var price1 in global scope? does window.price1 contain the value when you access it from the console? — cschuff
– cschuff, Commented Feb 10, 2014 at 21:26

laaposto · Accepted Answer · 2014-03-17 16:43:43Z

5

Your if is wrong. There is no operator or. In javascript operator or is declared with ||

You can read more for logical operators here.

Try

var price1 = 0;

if ((current_value == "msc") || (current_value == "phd")) {
    price1 = 150;
}
else {
    price1 = 250;
}

Also i suppose that above this block of code you initialize somewhere current_value

DEMO

edited Mar 17, 2014 at 16:43

answered Feb 10, 2014 at 21:26

laaposto

12.2k15 gold badges60 silver badges73 bronze badges

Sign up to request clarification or add additional context in comments.

3 Comments

cschuff Over a year ago

price1 should be initialized even with the broken if

laaposto Over a year ago

@cschuff price1 is initialized to 0. The OP dont gine the declaration of current_value which i suppose is somewhere above with the rest of the code

cschuff Over a year ago

well, you are right. if setting the innerHTML is executed on the same 'thread' it will break. an uninitialized 'current_value' will not break anything though.

Collectives™ on Stack Overflow

Display javascript variable in html

1 Answer 1

3 Comments

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

3 Comments

Related