angularjs getting data from a url

Question

I want to get json data from the url and assign it to a variable. I use a service that looks like this

app.service('dataService', function($http) {
  this.getdata = function(callbackFunc) {
    $http({
        method: 'GET',
        url: '/records/json/',
     }).success(function(data){
        // With the data succesfully returned, call our callback
        callbackFunc(data);
    }).error(function(){
        alert("error");
    });
 }
});

and my controller looks like this

app.controller('ReCtrl', ['$scope', function($scope, dataService){ 
   dataService.getdata(function(dataResponse) {
      $scope.fields = dataResponse; 
   });
   ....

But I get error TypeError: Cannot read property 'getdata' of undefined. I dont know what i am doing wrong. I appreciate any help.

musically_ut · Accepted Answer · 2015-04-22 13:24:35Z

4

You are not injecting your service (dataService) into your controller:

app.controller('ReCtrl', 
   ['$scope', 'dataService', function($scope, dataService){ 
   dataService.getdata(function(dataResponse) {
      $scope.fields = dataResponse; 
   });
   ....

Note the extra string 'dataService' after '$scope' while defining the controller ReCtrl.

answered Apr 22, 2015 at 13:24

musically_ut

34.3k9 gold badges98 silver badges110 bronze badges

Sign up to request clarification or add additional context in comments.

1 Comment

Leah Collins Over a year ago

Thanks, noob mistake. I appreciate your help.

Collectives™ on Stack Overflow

angularjs getting data from a url

1 Answer 1

1 Comment

Hot Network Questions

Collectives™ on Stack Overflow

1 Answer 1

1 Comment

Related