shell script doesn't write into file

Question

I just want to write a little shell script, which restarts my dosbox everytime it crashes.

#!/bin/bash
while [ "1" == "1" ]
do
  test=$(pgrep dosbox)
  if [ "$test" == '' ]
    then
      date + "%d-%m-%y     %T" >> autostartLog.txt
      dosbox emulator
  fi
done

and it restarts fine, but I can't write into my autostartLogs.txt.

I tried

echo $(date + "%d-%m-%y     %T) >> autostartLog.txt

in the terminal and it worked perfectly, but if I use it in my script it doesn't do anything.

edit: used checker, but it still doesn't write.

Consider pasting your code in shellcheck.net first, since it contains some syntax errors (hint: test =$(...) is wrong, know why). — fedorqui
– fedorqui, Commented Aug 18, 2016 at 8:47
Run the script as bash -x script-name. My date command fails if there is ` space after the + — cdarke
– cdarke, Commented Aug 18, 2016 at 8:59
@streber As previously mentioned, date probably doesn't like the space after the +. Does date + "%d-%m-%y %T" work when run manually? Could you try adding set -ex to the top of the script? — Biffen
– Biffen, Commented Aug 18, 2016 at 9:08
@streber date + "%d-%m-%y %T" with a space prints a date? Mine doesn't. Now I'm confused about what works and what doesn't (and what's this about terminal windows?!). Could you clarify, perhaps edit the question? (set -ex wasn't supposed to solve as much as help debug.) — Biffen
– Biffen, Commented Aug 18, 2016 at 9:16

cdarke · Accepted Answer · 2016-08-18 09:21:44Z

3

Your test is suspect. A better way would be:

#!/bin/bash

while :      # Tidier infinite loop
do
  if ! pgrep dosbox          # Note we are testing the failure of the pgrep
  then
      date "+%d-%m-%y     %T" >> autostartLog.txt
      dosbox emulator
  fi
done

edited Aug 18, 2016 at 9:21

answered Aug 18, 2016 at 9:07

cdarke

44.8k8 gold badges85 silver badges86 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Thirupathi Thangavel · Accepted Answer · 2016-08-18 09:17:28Z

1

date: No space between + and "

date +"%d-%m-%y %T" >> autostartLog.txt should work

answered Aug 18, 2016 at 9:17

Thirupathi Thangavel

2,5154 gold badges32 silver badges51 bronze badges

Collectives™ on Stack Overflow

shell script doesn't write into file

2 Answers 2

Comments

Comments

Linked

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

Comments

Comments

Linked

Related