User inputted integer using while statement

Question

Ok need to understand why my code is not working. At the moment it's getting stuck in a infinite loop of asking the user for a pin after a wrong pin is inputted.

I believe I'm screwing up the while statement somehow.

def inputValidator():
    userInput = requestInteger("Please input a PIN between 1 - 1000")
    while 1 > userInput > 1000 : 
        requestInteger("Your PIN is not within 1 - 1000, please try again")
    print("Thanks! your new PIN is " + str(userInput))

thanks for the help guys!

gus27 · Accepted Answer · 2016-10-03 13:02:30Z

2

Try this:

def inputValidator():
    userInput = requestInteger("Please input a PIN between 1 - 1000")
    while userInput<1 or userInput>1000:
        userInput = requestInteger("Your PIN is not within 1 - 1000, please try again")
    print("Thanks! your new PIN is " + str(userInput))

You'll want a new input from your user if userInput is smaller than 1 or bigger than 1000 - and like @Polina F. said - you didn't assign a new value to userInput inside the while loop. This is why it loops for ever.

edited Oct 3, 2016 at 13:02

answered Oct 3, 2016 at 12:56

gus27

2,6671 gold badge23 silver badges25 bronze badges

Sign up to request clarification or add additional context in comments.

Comments

Polina F. · Accepted Answer · 2016-10-03 12:54:53Z

1

You don't assign nothing in the while loop. userInput never gets updated - hence you can't exit the loop

answered Oct 3, 2016 at 12:54

Polina F.

64913 silver badges33 bronze badges

Comments

Mohammad Athar · Accepted Answer · 2016-10-03 12:55:20Z

1

you aren't assigning requestInteger to userInput

while 1 > userInput > 1000 : 
  userInput =requestInteger("Your PIN is not within 1 - 1000, please try again")

answered Oct 3, 2016 at 12:55

Mohammad Athar

1,9802 gold badges15 silver badges36 bronze badges

Collectives™ on Stack Overflow

User inputted integer using while statement

3 Answers 3

Comments

Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

3 Answers 3

Comments

Comments

Comments

Related