Sorting of Array of Objects not working with Array.sort() method

Question

I am attempting to sort an array of objects by a name property that exists on each object. When using the sort() method with the code below I am getting the following error:

ERROR ReferenceError: b is not defined

Here is my code:

myArray.sort( (a, b) => {
return (typeof a.name: string === 'string') - (typeof b.name === 'string')|| a.name - b.name || a.name.localeCompare(b.name)};

Here is what is odd though...

When I run:

myArray.sort( (a, b) => {
console.log(a.name);
console.log(b.name);

It logs the names perfectly fine. What am I missing??

Just to be a thorough little bit of context:

I am using this method after doing an HTTP call from an angular service.ts file and this array is being passed to my component and subscribed to. And I am using Angular, so this would be Typescript compiling to JavaScript. I also have another myArray.forEach() method just below my sort() method and that is working.

The subtraction operator doesn't work on string values; what is it that you expect that expression to do? — Pointy
– Pointy, Commented Mar 17, 2018 at 15:14
With that many || operators, you would be best to add parentheses throughout, but really, you might want to go back to using something easier to debug using good old-fashioned if .. else — vol7ron
– vol7ron, Commented Mar 17, 2018 at 15:17
Please add a minimal, complete and verifiable example which shows the actual problem. — Andreas
– Andreas, Commented Mar 17, 2018 at 15:20

SMAKSS · Accepted Answer · 2022-10-25 06:59:07Z

17

Is this what you want?

var a = [
  { name: "John" },
  { name: "Jack" },
  { name: "Bob" }
];

a.sort(function (a, b) {
  if (a.name > b.name) return 1;
  if (a.name < b.name) return -1;
  return 0;
});

console.log(a);

edited Oct 25, 2022 at 6:59

SMAKSS

10.6k3 gold badges26 silver badges38 bronze badges

answered Mar 17, 2018 at 15:26

user1636522

Sign up to request clarification or add additional context in comments.

2 Comments

newman Over a year ago

This worked. Thank you! I am new to TypeScript and working out some of the kinks. Maybe I should maybe just stick to writing JS for my projects

user1636522 Over a year ago

@newman As you wish, I guess you know that TypeScript is a superset of JavaScript, hence you can use JS when you are not sure how to do it with TS :-)

Nina Scholz · Accepted Answer · 2018-03-17 15:35:27Z

1

You could use a comparison which works independently of the type of string or number, by moving numerical values to top.

var array = [{ name: 20 }, { name: 21 }, { name: 2 }, { name: 11 }, { name: 1 }, { name: 'John' }, { name: 'Jane' }, { name: 'Frank' }, { name: 'Mary' },] 

array.sort((a, b) => (typeof a.name === 'string') - (typeof b.name === 'string') || a.name > b.name || -(a.name < b.name));

console.log(array);

answered Mar 17, 2018 at 15:35

Nina Scholz

388k26 gold badges367 silver badges417 bronze badges

Collectives™ on Stack Overflow

Sorting of Array of Objects not working with Array.sort() method

2 Answers 2

2 Comments

Comments

Hot Network Questions

Collectives™ on Stack Overflow

2 Answers 2

2 Comments

Comments

Related